Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Circle CI #22

Merged
merged 4 commits into from Jan 14, 2019
Merged

Conversation

Bhargavasomu
Copy link
Contributor

What was wrong?

Fixes #21

Cute Animal Picture

Cute animal picture

@Bhargavasomu
Copy link
Contributor Author

@pipermerriam could you please do the honor?

@Bhargavasomu
Copy link
Contributor Author

With this PR, the following things are done.

  • library versions and their bounds have been updated to meet the latest versions.
  • python 3.4 support has been dropped, which was stated in PR Drops python3.4 support #20

Please let me know if any unnecessary libraries have been added to setup.py

Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small cleanup if you're up for it.

setup.py Outdated Show resolved Hide resolved
@Bhargavasomu
Copy link
Contributor Author

@pipermerriam done, please check now.

@pipermerriam pipermerriam merged commit 2b46bb5 into ethereum:master Jan 14, 2019
This was referenced Jan 22, 2019
pacrob pushed a commit to pacrob/eth-keyfile that referenced this pull request Nov 2, 2023
Remove attribution to specific person, update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants