Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make denoms a real class #154

Merged

Conversation

Projects
None yet
2 participants
@pipermerriam
Copy link
Member

commented Apr 22, 2019

What was wrong?

The eth_utils.denoms object doesn't have type information for it's attributes since it is dynamically created using type(...)

How was it fixed?

Updated it to explicitly name all of the units and added a test to ensure that all units from eth_utils.units are present on the class.

Cute Animal Picture

unlikely-animals-sleeping-together-posted-at-awesomelycute com-9

@pipermerriam pipermerriam requested a review from njgheorghita Apr 22, 2019

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/make-denoms-a-real-class branch 4 times, most recently from 89e9f33 to 01b02a0 Apr 22, 2019

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/make-denoms-a-real-class branch from 01b02a0 to 1ebaa3b Apr 22, 2019

@pipermerriam pipermerriam changed the title Piper/make denoms a real class Make denoms a real class Apr 22, 2019

@njgheorghita
Copy link
Contributor

left a comment

👍 In terms of pinning mypy directly to 0.701 is that intended to be the standard for a while? I'll start on updating my libraries to the same version

@pipermerriam pipermerriam merged commit 7434a37 into ethereum:master Apr 23, 2019

5 checks passed

ci/circleci: doctest Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py35 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: pypy3 Your tests passed on CircleCI!
Details

@pipermerriam pipermerriam deleted the pipermerriam:piper/make-denoms-a-real-class branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.