Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hinting for replace_exceptions #155

Merged

Conversation

Projects
None yet
2 participants
@pipermerriam
Copy link
Member

commented Apr 22, 2019

What was wrong?

The replace_exceptions helper had incorrect type hints.

How was it fixed?

Fixed type hints to expect classes instead of instances.

Cute Animal Picture

goats-goats-goats

@pipermerriam pipermerriam requested a review from njgheorghita Apr 22, 2019

@@ -34,7 +34,7 @@ basepython=python3.6
extras=lint
commands=
flake8 {toxinidir}/eth_utils
mypy --follow-imports=silent --ignore-missing-imports --disallow-incomplete-defs -p eth_utils
mypy --follow-imports=silent --ignore-missing-imports --disallow-incomplete-defs --warn-unused-ignore -p eth_utils

This comment has been minimized.

Copy link
@njgheorghita

njgheorghita Apr 23, 2019

Contributor

ahh cool flag - will probably mirror this in my libraries

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/fix-replace-exceptions-type branch 4 times, most recently from 62ea55a to 02764c8 Apr 23, 2019

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/fix-replace-exceptions-type branch from 02764c8 to deef467 Apr 23, 2019

@pipermerriam pipermerriam merged commit d988975 into ethereum:master Apr 25, 2019

5 checks passed

ci/circleci: doctest Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py35 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: pypy3 Your tests passed on CircleCI!
Details

@pipermerriam pipermerriam deleted the pipermerriam:piper/fix-replace-exceptions-type branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.