Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface files to MANIFEST.in #181

Merged
merged 2 commits into from Dec 4, 2019

Conversation

@njgheorghita
Copy link
Contributor

njgheorghita commented Dec 4, 2019

What was wrong?

  • .pyi files were not being included in the distributions.
  • Fix broken combomethod type hints.

How was it fixed?

Added a global-include for .pyi files in MANIFEST.in

To-Do

  • Clean up commit history

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the njgheorghita:update-manifest branch from 900c368 to 569ba1d Dec 4, 2019
@njgheorghita njgheorghita force-pushed the njgheorghita:update-manifest branch from 569ba1d to b685ca7 Dec 4, 2019
@njgheorghita njgheorghita requested a review from pipermerriam Dec 4, 2019
@@ -11,7 +11,7 @@ class combomethod(object):
def __init__(self, method: Callable[..., Any]) -> None:
self.method = method

def __get__(self, obj: T = None, objtype: Type[T] = None) -> Callable[..., T]:
def __get__(self, obj: T = None, objtype: Type[T] = None) -> Callable[..., Any]:

This comment has been minimized.

Copy link
@njgheorghita

njgheorghita Dec 4, 2019

Author Contributor

@pipermerriam @cburgdorf This type hint was buggy. But it seems to me like an Any might be appropriate here since a method with the combomethod decorator can return any value - unless I'm missing any possible way to preserve the type of what the decorated function returns?

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Dec 4, 2019

Member

I think to get the typing right this would need to be a Generic but it doesn't seem like it would play nicely with typing...

class combomethod(Generic[T]):
    ...
@njgheorghita njgheorghita merged commit 71a745b into ethereum:master Dec 4, 2019
10 checks passed
10 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint-py36 Your tests passed on CircleCI!
Details
ci/circleci: lint-py37 Your tests passed on CircleCI!
Details
ci/circleci: lint-py38 Your tests passed on CircleCI!
Details
ci/circleci: py35 Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details
ci/circleci: py36-typing1 Your tests passed on CircleCI!
Details
ci/circleci: py37 Your tests passed on CircleCI!
Details
ci/circleci: py38 Your tests passed on CircleCI!
Details
ci/circleci: pypy3 Your tests passed on CircleCI!
Details
@njgheorghita njgheorghita deleted the njgheorghita:update-manifest branch Dec 4, 2019
@njgheorghita njgheorghita mentioned this pull request Dec 5, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.