New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder: avoid Eth1 mistakes #9

Open
mratsim opened this Issue Dec 27, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@mratsim
Copy link
Collaborator

mratsim commented Dec 27, 2018

Continuation from status-im/eth2-testgen#1 (comment)

One mistake that was done in Eth1 was having all tests available directly in the repo.
This led to hard-to-review PRs with 8k lines changed to unreviewable PRs with 1M lines changed.

Proposition

Keep small subsets of tests in yaml files in the repo as it allows easy inspection and promotes discussion, but complete tests should be generated during CI by Travis/Appveyor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment