Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ethereum Foundation YouTube to Footer #665

Merged
merged 4 commits into from Jan 7, 2020
Merged

Conversation

@edsonayllon
Copy link
Contributor

edsonayllon commented Dec 26, 2019

Description

Adds link to the official Ethereum YouTube to the footer.

Related Issue

#664

Screenshots (if appropriate):

Screen Shot 2019-12-26 at 12 52 37 PM

Copy link
Collaborator

samajammin left a comment

Thanks for submitting this PR! One question on the change of dependencies.

yarn.lock Outdated
version "2.1.1"
resolved "https://registry.yarnpkg.com/serialize-javascript/-/serialize-javascript-2.1.0.tgz#9310276819efd0eb128258bb341957f6eb2fc570"
integrity sha512-a/mxFfU00QT88umAJQsNWOnUKckhNCqOl028N48e7wFmo2/EHpTo9Wso+iJJCMrQnmFvcjto5RJdAHEvVhcyUQ==
serialize-javascript@^2.1.0:

This comment has been minimized.

Copy link
@samajammin

samajammin Dec 29, 2019

Collaborator

Why this change? Doesn't seem relevant to this PR.

This comment has been minimized.

Copy link
@edsonayllon

edsonayllon Dec 29, 2019

Author Contributor

I just ran yarn, yarn dev to see the changes locally. Must have updated the dependencies. I can revert those changes later today if you'd like.

This comment has been minimized.

Copy link
@edsonayllon

edsonayllon Dec 29, 2019

Author Contributor

Actually, had time before my flight. 146ee80

@edsonayllon edsonayllon requested a review from samajammin Jan 3, 2020
@samajammin samajammin requested a review from jjmstark Jan 3, 2020
Copy link
Collaborator

samajammin left a comment

LGTM - @jjmstark what do you think?

@samajammin samajammin merged commit 556d236 into ethereum:dev Jan 7, 2020
5 checks passed
5 checks passed
Header rules - ethereumorg No header rules processed
Details
Pages changed - ethereumorg 141 new files uploaded
Details
Mixed content - ethereumorg No mixed content detected
Details
Redirect rules - ethereumorg 12 redirect rules processed
Details
netlify/ethereumorg/deploy-preview Deploy preview ready!
Details
@samajammin

This comment has been minimized.

Copy link
Collaborator

samajammin commented Jan 7, 2020

Thanks again for this PR & the descriptive issue ❤️

@samajammin

This comment has been minimized.

Copy link
Collaborator

samajammin commented Jan 7, 2020

@all-contributors please add @edsonayllon for content

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Jan 7, 2020

@samajammin

I've put up a pull request to add @edsonayllon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.