Update smart contracts index.md#7759
Merged
Merged
Conversation
As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was *not* thinking what the text suggested about contracts ;)). Also, the lead sentence should say what smart contracts *are* rather than emphasizing their importance or place in the ecosystem. Last, I rejiggered some of the passive voice sentences . Enjoy 😃
setgree
requested review from
corwintines,
jmcook1186,
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
github-actions
Bot
added
content 🖋️
setgree
changed the title
ostapenko93
approved these changes
Sep 8, 2022
✅ ethereum-org-website-dev deploy preview ready
|
minimalsm
reviewed
Sep 9, 2022
setgree
commented
Sep 9, 2022
setgree
commented
Sep 9, 2022
jmcook1186
suggested changes
Sep 13, 2022
jmcook1186
left a comment
jmcook1186
left a comment
Contributor
There was a problem hiding this comment.
added some suggestions for minor changes but overall LGTM
wackerow
reviewed
Sep 13, 2022
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
jmcook1186
approved these changes
Sep 22, 2022
jmcook1186
left a comment
jmcook1186
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your work on this @setgree. There were a range of opinions on various parts of the page and it seemed to be going a bit stale, so I've made some decisions on it to get it moving. Approving now.
samajammin
reviewed
Sep 22, 2022
samajammin
reviewed
Sep 22, 2022
samajammin
reviewed
Sep 22, 2022
Member
|
Just writting some edits to propose. Will put those up this week. |
wackerow
reviewed
Nov 28, 2022
Co-authored-by: Sam Richards <sbrichards@gmail.com>
return h1, required for pages using static template
wackerow
approved these changes
Aug 9, 2023
Member
|
Sorry for delays here @setgree! Circled back, pushed an adjustment to address @samajammin's comments, and added the H1 back in which is required on pages that use the default markdown template. Merging on build finish.. thanks again! |
Contributor
Author
|
Glad to hear it! If there are any more pages that need some attention, I
would be happy to take a look.
On Wed, Aug 9, 2023 at 12:40 PM Paul Wackerow ***@***.***> wrote:
Sorry for delays here @setgree <https://github.com/setgree>! Circled
back, pushed an adjustment to address @samajammin
<https://github.com/samajammin>'s comments, and added the H1 back in
which is required on pages that use the default markdown template. Merging
on build finish.. thanks again!
—
Reply to this email directly, view it on GitHub
<#7759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLE3UQSK7AB3DHL4VUKR6LXUO4QFANCNFSM6AAAAAAQIEBGMU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Seth Green
|
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Member
|
@all-contributors can you add @setgree for content |
Contributor
|
I've put up a pull request to add @setgree! 🎉 |
This was referenced Aug 16, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was not thinking what the text suggested about contracts ;)).
Also, the lead sentence should say what smart contracts are rather than emphasizing their importance or place in the ecosystem.
Last, I rejiggered some of the passive voice sentences.
EDIT: three small additions:
to be
Enjoy 😃
Description
Related Issue