Skip to content

Update smart contracts index.md #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Update smart contracts index.md #7759

merged 7 commits into from
Aug 10, 2023

Conversation

setgree
Copy link
Contributor

@setgree setgree commented Sep 8, 2022

As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was not thinking what the text suggested about contracts ;)).

Also, the lead sentence should say what smart contracts are rather than emphasizing their importance or place in the ecosystem.

Last, I rejiggered some of the passive voice sentences.

EDIT: three small additions:

  1. the first sentence can be split into two, like so:

Smart contracts are digital contracts on the blockchain. When a smart contract's terms are met, the contract automatically executes the outcome that the parties agreed to.

  1. I misspelled Nick Szabo's last name
  2. redo this sentence

Smart contracts can do essentially anything that a computer programs do.

to be

Smart contracts can do essentially anything that computer programs can do.

Enjoy 😃

Description

Related Issue

As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was *not* thinking what the text suggested about contracts ;)). 

Also, the lead sentence should say what smart contracts *are* rather than emphasizing their importance or place in the ecosystem.

Last, I rejiggered some of the passive voice sentences .

Enjoy 😃
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 labels Sep 8, 2022
@setgree setgree changed the title Update index.md Update smart contracts' index.md Sep 8, 2022
@setgree setgree changed the title Update smart contracts' index.md Update smart contracts index.md Sep 8, 2022
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 8, 2022

✅ ethereum-org-website-dev deploy preview ready

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @setgree :-) thanks for the PR here 😎 . Some nice improvements 💪 There are a few changes I'm not so sure of, but I'd like to get some other opinions here to remove my bias as the original author.

Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some suggestions for minor changes but overall LGTM

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@setgree Thanks for this! Left some comments =)

jmcook1186 and others added 2 commits September 22, 2022 14:07
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com>
Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @setgree. There were a range of opinions on various parts of the page and it seemed to be going a bit stale, so I've made some decisions on it to get it moving. Approving now.

@corwintines
Copy link
Member

Just writting some edits to propose. Will put those up this week.

@corwintines corwintines self-assigned this Jan 30, 2023
wackerow and others added 2 commits August 9, 2023 16:26
Co-authored-by: Sam Richards <sbrichards@gmail.com>
return h1, required for pages using static template
@wackerow wackerow requested a review from nhsz as a code owner August 9, 2023 16:30
@wackerow
Copy link
Member

wackerow commented Aug 9, 2023

Sorry for delays here @setgree! Circled back, pushed an adjustment to address @samajammin's comments, and added the H1 back in which is required on pages that use the default markdown template. Merging on build finish.. thanks again!

@setgree
Copy link
Contributor Author

setgree commented Aug 9, 2023 via email

@wackerow wackerow merged commit 34cd6f8 into ethereum:dev Aug 10, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Aug 10, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team.

GitPOAP: 2023 Ethereum.org Contributor:

GitPOAP: 2023 Ethereum.org Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@corwintines
Copy link
Member

@all-contributors can you add @setgree for content

@allcontributors
Copy link
Contributor

@corwintines

I've put up a pull request to add @setgree! 🎉

This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants