-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update smart contracts index.md #7759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was *not* thinking what the text suggested about contracts ;)). Also, the lead sentence should say what smart contracts *are* rather than emphasizing their importance or place in the ecosystem. Last, I rejiggered some of the passive voice sentences . Enjoy 😃
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @setgree :-) thanks for the PR here 😎 . Some nice improvements 💪 There are a few changes I'm not so sure of, but I'd like to get some other opinions here to remove my bias as the original author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some suggestions for minor changes but overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@setgree Thanks for this! Left some comments =)
Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @setgree. There were a range of opinions on various parts of the page and it seemed to be going a bit stale, so I've made some decisions on it to get it moving. Approving now.
Just writting some edits to propose. Will put those up this week. |
Co-authored-by: Sam Richards <sbrichards@gmail.com>
return h1, required for pages using static template
Sorry for delays here @setgree! Circled back, pushed an adjustment to address @samajammin's comments, and added the H1 back in which is required on pages that use the default markdown template. Merging on build finish.. thanks again! |
Glad to hear it! If there are any more pages that need some attention, I
would be happy to take a look.
On Wed, Aug 9, 2023 at 12:40 PM Paul Wackerow ***@***.***> wrote:
Sorry for delays here @setgree <https://github.com/setgree>! Circled
back, pushed an adjustment to address @samajammin
<https://github.com/samajammin>'s comments, and added the H1 back in
which is required on pages that use the default markdown template. Merging
on build finish.. thanks again!
—
Reply to this email directly, view it on GitHub
<#7759 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLE3UQSK7AB3DHL4VUKR6LXUO4QFANCNFSM6AAAAAAQIEBGMU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Seth Green
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! Be sure to join the Ethereum.org discord if you are interested in contributing further to the project or have any questions for the team. GitPOAP: 2023 Ethereum.org Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
@all-contributors can you add @setgree for content |
I've put up a pull request to add @setgree! 🎉 |
As it was, much of this piece seemed to be trying to pitch people on the idea of smart contracts, and given the venue, I think straightforward explanation is more appropriate. I removed some of the sales-y language and also removed rhetorical devices (e.g. the text suggesting what the reader thinks -- I for one was not thinking what the text suggested about contracts ;)).
Also, the lead sentence should say what smart contracts are rather than emphasizing their importance or place in the ecosystem.
Last, I rejiggered some of the passive voice sentences.
EDIT: three small additions:
to be
Enjoy 😃
Description
Related Issue