From 7db4151bcf6c36de17fb2d435a53a6fd307a329d Mon Sep 17 00:00:00 2001 From: allboxes Date: Thu, 8 Dec 2022 11:26:12 -0700 Subject: [PATCH 1/2] Add blockValue to engine_getPayloadV2 Apply suggestions from code review Co-authored-by: Mikhail Kalinin Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> --- src/engine/shanghai.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/engine/shanghai.md b/src/engine/shanghai.md index 0c7b12eb..8b49baee 100644 --- a/src/engine/shanghai.md +++ b/src/engine/shanghai.md @@ -121,12 +121,17 @@ This method follows the same specification as [`engine_forkchoiceUpdatedV1`](./p * method: `engine_getPayloadV2` * params: 1. `payloadId`: `DATA`, 8 Bytes - Identifier of the payload build process +* timeout: 1s #### Response -* result: [`ExecutionPayloadV2`](#ExecutionPayloadV2) +* result: `object` + - `executionPayload`: [`ExecutionPayloadV2`](#ExecutionPayloadV2) + - `blockValue` : `QUANTITY`, 256 Bits - The expected value to be received by the `feeRecipient` in wei * error: code and message set in case an exception happens while getting the payload. #### Specification -Refer to the specification for [`engine_getPayloadV1`](./paris.md#engine_getpayloadv1). +This method follows the same specification as [`engine_getPayloadV1`](#engine_getpayloadv1) with the addition of the following: + + 1. Client software **SHOULD** use the sum of the block's priority fees or any other algorithm to determine `blockValue`. \ No newline at end of file From 86c03a06ee91b8c69d245b945fdaa7ffbf88dfb8 Mon Sep 17 00:00:00 2001 From: allboxes Date: Sat, 24 Dec 2022 10:03:55 -0700 Subject: [PATCH 2/2] Fix reference path --- src/engine/shanghai.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/engine/shanghai.md b/src/engine/shanghai.md index 8b49baee..52d733a3 100644 --- a/src/engine/shanghai.md +++ b/src/engine/shanghai.md @@ -132,6 +132,6 @@ This method follows the same specification as [`engine_forkchoiceUpdatedV1`](./p #### Specification -This method follows the same specification as [`engine_getPayloadV1`](#engine_getpayloadv1) with the addition of the following: +This method follows the same specification as [`engine_getPayloadV1`](./paris.md#engine_getpayloadv1) with the addition of the following: 1. Client software **SHOULD** use the sum of the block's priority fees or any other algorithm to determine `blockValue`. \ No newline at end of file