Allow functions to be defined outside of contracts #566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Utility functions couldn't be defined at the module level, they had to be inside of contracts.
How was it fixed?
Nothing too complicated here. Note that every module-level fn will be compiled into every contract (in yul) for now (but a
pub
module-level fn doesn't become a public contract function). Someday soon I hope to change the yulgen to only include things that are used.I didn't update the spec. I figured module functions should be discussed in the section on modules that doesn't exist yet, and also I just didn't really feel like updating it 馃し
The grammar file contains a small lie;
self
isn't allowed in module function parameter lists. Feeling lazy, I guess.To-Do
OPTIONAL: Update Spec if applicable
Add entry to the release notes (may forgo for trivial changes)
Clean up commit history