Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate string literals to only allow a subset of ASCII chars #506

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

cburgdorf
Copy link
Collaborator

@cburgdorf cburgdorf commented Aug 10, 2021

What was wrong?

As described in #329 we aren't yet validating string literals properly which causes our compiler to crash at the YUL stage (since YUL does perform that check)

How was it fixed?

Added an analyzer check + tests + spec update

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #506 (fa481cf) into master (c8e58b5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head fa481cf differs from pull request most recent head b784524. Consider uploading reports for the commit b784524 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   87.69%   87.71%   +0.01%     
==========================================
  Files          80       80              
  Lines        5276     5284       +8     
==========================================
+ Hits         4627     4635       +8     
  Misses        649      649              
Impacted Files Coverage Δ
crates/analyzer/src/traversal/expressions.rs 90.90% <100.00%> (+0.13%) ⬆️
crates/yulgen/src/lib.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e58b5...b784524. Read the comment docs.

@cburgdorf cburgdorf force-pushed the christoph/feat/ascii branch from 20f4179 to b784524 Compare August 11, 2021 12:52
@cburgdorf cburgdorf requested a review from g-r-a-n-t August 11, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants