Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved articulation of #overview #544

Merged
merged 1 commit into from Sep 13, 2021
Merged

Improved articulation of #overview #544

merged 1 commit into from Sep 13, 2021

Conversation

engagepy
Copy link
Contributor

@engagepy engagepy commented Sep 10, 2021

What was wrong?

The articulation of the overview heading was wobbly. Not reflecting precision and grace. 'and' was used twice in succession 'python and rust and' , making it awkward.

How was it fixed?

I rephrased while keeping the meaning precisely the same, and avoiding incorrect articulation methods. Minimal tweaking for a far better impact. Read it and see for yourself :)

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@g-r-a-n-t
Copy link
Member

Thank you! looks great.

Will merge once the build completes.

@codecov-commenter
Copy link

Codecov Report

Merging #544 (17f5e39) into master (f1327bb) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 17f5e39 differs from pull request most recent head 796425b. Consider uploading reports for the commit 796425b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   87.92%   87.91%   -0.01%     
==========================================
  Files          87       87              
  Lines        5654     5653       -1     
==========================================
- Hits         4971     4970       -1     
  Misses        683      683              
Impacted Files Coverage Δ
crates/analyzer/src/traversal/expressions.rs 92.11% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1327bb...796425b. Read the comment docs.

@g-r-a-n-t g-r-a-n-t merged commit 8ee4ed7 into ethereum:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants