Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzer crash #531 fix #546

Merged
merged 3 commits into from
Sep 24, 2021
Merged

fuzzer crash #531 fix #546

merged 3 commits into from
Sep 24, 2021

Conversation

g-r-a-n-t
Copy link
Member

@g-r-a-n-t g-r-a-n-t commented Sep 13, 2021

What was wrong?

closes #531

How was it fixed?

  • updated lowering tests to use AST printing and insta
  • added a test for tuple destructing
  • fixed 531 by appending a $ to the front of lowered tuple struct names
  • added a fuzzer crash regression test module and added a test for this PR

To-Do

  • OPTIONAL: Update Spec if applicable
  • Add entry to the release notes (may forgo for trivial changes)
  • Clean up commit history

@g-r-a-n-t g-r-a-n-t changed the title fuzzer crash 531 fix fuzzer crash #531 fix Sep 13, 2021
@g-r-a-n-t g-r-a-n-t force-pushed the agroce-531 branch 4 times, most recently from 8fa93cf to 8903511 Compare September 16, 2021 20:18
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #546 (ba366a6) into master (8ee4ed7) will decrease coverage by 0.34%.
The diff coverage is 74.50%.

❗ Current head ba366a6 differs from pull request most recent head 84421e3. Consider uploading reports for the commit 84421e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #546      +/-   ##
==========================================
- Coverage   87.91%   87.57%   -0.35%     
==========================================
  Files          87       87              
  Lines        5653     5907     +254     
==========================================
+ Hits         4970     5173     +203     
- Misses        683      734      +51     
Impacted Files Coverage Δ
crates/parser/src/ast.rs 76.82% <74.40%> (+12.89%) ⬆️
crates/lowering/src/names.rs 78.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eb0898...84421e3. Read the comment docs.

@g-r-a-n-t g-r-a-n-t force-pushed the agroce-531 branch 6 times, most recently from 0468bc3 to e7d6849 Compare September 22, 2021 20:09
@g-r-a-n-t g-r-a-n-t requested a review from sbillig September 23, 2021 22:29
Copy link
Collaborator

@sbillig sbillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 😎 👍

@g-r-a-n-t g-r-a-n-t merged commit 2e5bc2d into ethereum:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to analyze lowered AST (duplicate type name)
3 participants