New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: rename etherbase to coinbase #1420

Closed
ethers opened this Issue Jul 6, 2015 · 15 comments

Comments

Projects
None yet
10 participants
@ethers
Member

ethers commented Jul 6, 2015

If "etherbase" is really preferred over "coinbase", let's make it consistent everywhere.

The output of geth attach uses coinbase

Geth
Version: 0.9.35
Git Commit: aa45020
Protocol Versions: [61 60]
Network Id: 0
Go Version: go1.4.2

@obscuren

This comment has been minimized.

Member

obscuren commented Jul 6, 2015

Thanks. @bas-vk

@zelig

This comment has been minimized.

Contributor

zelig commented Jul 7, 2015

coinbase is the name used by RPC/web3.js too unfortunately

@alexvandesande

This comment has been minimized.

alexvandesande commented Jul 8, 2015

@radster360

This comment has been minimized.

radster360 commented Jul 8, 2015

Yes. I do agree that etherbase is probably the right term, but the nomenclature of "coinbase" so so out there, it will take some time. Someone referred to "etherbase" in one of the Skype group and I had to ask what was "etherbase"? Though maybe the respond from the team might have gotten lost somewhere, but I figured it was so when I used the "coinbase" value in my Geth CLI.

@tinybike

This comment has been minimized.

Member

tinybike commented Jul 9, 2015

For what it's worth, I prefer the term coinbase, just because people already know what that means. The less new jargon you can introduce, the better. (Also, in my opinion, "coinbase" is a lot nicer phonetically than "etherbase"...)

@obscuren

This comment has been minimized.

Member

obscuren commented Jul 9, 2015

Agreed. The issue I have with coin base is Ethereum doesn't have the concept of a coin like Bitcoin does.

On 09 Jul 2015, at 09:12, Jack Peterson notifications@github.com wrote:

For what it's worth, I prefer the term coinbase, just because people already know what that means. The less new jargon you can introduce, the better. (Also, in my opinion, "coinbase" is a lot nicer phonetically than "etherbase"...)


Reply to this email directly or view it on GitHub.

@zelig

This comment has been minimized.

Contributor

zelig commented Jul 9, 2015

etherbase is pretty transparent. for across the board consistency we could allow etherbase in rpc/js (keeping coinbase for backward compatibility).

@smartsmart123

This comment has been minimized.

smartsmart123 commented Jul 9, 2015

I think coinbase is the standard terminology for block reward transactions. Might as well keep it that way.

@fjl

This comment has been minimized.

Contributor

fjl commented Aug 9, 2015

So which one should it be, 'etherbase' or 'coinbase'?
Changing web3.js to use etherbase is going to spark some internal discussion,
but we can really pull this off if a lot of people want it.

@obscuren

This comment has been minimized.

Member

obscuren commented Aug 9, 2015

I think we'll have to change our own etherbase to coinbase. It's an adopted term and I'm quite fine going with that.

@fjl

This comment has been minimized.

Contributor

fjl commented Aug 9, 2015

Great.

@fjl fjl changed the title from etherbase vs coinbase to cmd/geth: rename etherbase to coinbase Aug 9, 2015

@fjl fjl added this to the Homestead milestone Aug 9, 2015

@obscuren obscuren added I *** labels Sep 23, 2015

@tgerring

This comment has been minimized.

Member

tgerring commented Oct 8, 2015

Quick search for anyone deciding to work on this task:

https://github.com/ethereum/go-ethereum/search?utf8=%E2%9C%93&q=etherbase

@fjl fjl removed this from the Homestead milestone Jan 17, 2016

@fjl

This comment has been minimized.

Contributor

fjl commented Jan 17, 2016

Not gonna happen for Homestead.

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 26, 2017

Renamed Coinbase to Etherbase, fixes ethereum#1420
Leaves the values in the json named "coinbase" for backwards compatibility.

Touches cmd/geth, consensus, console, core/vm, eth, les, internal/ethapi,
internal/jsre, light, miner, mobile.

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 26, 2017

cmd/geth, consensus, console, core/vm, eth, les, internal/ethapi, int…
…ernal/jsre, light, miner, mobile

Renamed Coinbase to Etherbase, fixes ethereum#1420

Leaves the values in the json named "coinbase" for backwards compatibility.

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 26, 2017

cmd/geth, consensus, console, core/vm, eth, les, rename coinbase to e…
…therbase

Renamed Coinbase to Etherbase, fixes ethereum#1420

Leaves the values in the json named "coinbase" for backwards compatibility.

Also touches internal/ethapi, internal/jsre, light, miner, mobile

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 26, 2017

cmd/geth, consensus, console, core/vm, eth, les: rename coinbase to e…
…therbase

Renamed Coinbase to Etherbase, fixes ethereum#1420

Leaves the values in the json named "coinbase" for backwards compatibility.

Also touches internal/ethapi, internal/jsre, light, miner, mobile

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 27, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420
@dherbst

This comment has been minimized.

Contributor

dherbst commented Sep 27, 2017

I put PR #15211 up for this. Looks like one of the travis tests timed out. Please let me know if you have any feedback on the PR.

dherbst added a commit to dherbst/go-ethereum that referenced this issue Sep 28, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Oct 6, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Oct 9, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Oct 10, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Oct 14, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Nov 9, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420

dherbst added a commit to dherbst/go-ethereum that referenced this issue Dec 22, 2017

cmd console, eth, internal/web3ext les miner: changed etherbase to co…
…inbase

Changed etherbase to coinbase, leaving the command line flag in place for
now to avoid a hard cutover.

Fixes ethereum#1420
@stale

This comment has been minimized.

stale bot commented Sep 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 28, 2018

@stale stale bot closed this Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment