New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid transaction v,r,s values with geth when reading from of signed MEW RLP transaction #14599

Closed
ligi opened this Issue Jun 8, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ligi
Member

ligi commented Jun 8, 2017

System information

Geth version: 1.6.5
OS & Version: Android

Expected behaviour

Should be able to read the from field and not throw "Invalid transaction v,r,s values"

Actual behaviour

throws "Invalid transaction v,r,s values" when reading from field

Steps to reproduce the behaviour

  1. generate a signed transaction RLP with MEW ( e.g. 0xf86b80847735940082520894ef5bbb9bba2e1ca69ef81b23a8727d889f3ef0a1880de0b6b3a7640000802ba06fef16c44726a102e6d55a651740636ef8aec6df3ebf009e7b0c1f29e4ac114aa057e7fbc69760b522a78bb568cfc37a58bfdcf6ea86cb8f9b550263f58074b9cc )
  2. convert to geth transaction via Geth.newTransactionFromRLP(hex)
  3. try to access the from field ( will throw "Invalid transaction v,r,s values")

I can successfully read fields like value or to
When generating the RLP with geth like this:

Geth.newTransactionFromRLP(transactionWithSignature.encodeRLP())

I can access the from field.

Hint from Péter Szilágyi (@karalabe) on gitter: Hmmm, one bet is that the mobile library might be using homestead signatures and mew returning proper eip155

Also as a question on stackoverflow:
https://ethereum.stackexchange.com/questions/17385/invalid-transaction-v-r-s-values-with-geth-when-reading-from-of-signed-mew-rlp-t
Unfortunately it does not get any attention there and there is growing evidence that this is a problem with (the mobile API of) geth

@bas-vk

This comment has been minimized.

Show comment
Hide comment
@bas-vk

bas-vk Jun 9, 2017

Member

Péters guess is correct. This method uses the hard coded homestead signer during decoding.
Will create a fix.

Member

bas-vk commented Jun 9, 2017

Péters guess is correct. This method uses the hard coded homestead signer during decoding.
Will create a fix.

@ligi

This comment has been minimized.

Show comment
Hide comment
@ligi

ligi Jun 9, 2017

Member

Thanks so much!

Member

ligi commented Jun 9, 2017

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment