Always fail when the contract call external contract #16931

dksuper · 2018-06-08T10:23:00Z

System information

Geth version: 1.8.7
OS & Version: Linux

Expected behaviour

Always fail when the contract call external contract

Actual behaviour

I don't know why , but it always cost all gas!

it work fine on geth 1.6.x

The text was updated successfully, but these errors were encountered:

jeichel-miovision · 2018-06-08T16:28:35Z

I'm seeing the same thing. I tested the following code on Ropsten and it works as expected.

pragma solidity ^0.4.23;

contract Producer {
  uint8 public SOME_VALUE=12;
}

contract Consumer {
    Producer currentProducer;

    function setProducer(address addr) public { 
        Producer newProducer = Producer(addr);
        require(newProducer.SOME_VALUE() > 0);
        currentProducer = newProducer; 
    }

    function getSome() public view returns (uint8) {
        return currentProducer.SOME_VALUE(); 

    }
}

Code reproduced from https://ethereum.stackexchange.com/questions/48833/calling-external-contract-leads-to-infinite-gas-need

Geth
Version: 1.8.10-stable
Git Commit: eae63c511ceafab14b92e274c1b18bf1700e2d3d
Architecture: amd64
Protocol Versions: [63 62]
Network Id: 1
Go Version: go1.10
Operating System: linux
GOPATH=
GOROOT=/usr/lib/go-1.10

jeichel-miovision · 2018-06-08T19:57:48Z

a bit more follow-up...

looks like the issue might be related to the compiler version as well as go-ehtereum version.

The following code runs for Tester: Tester.create(), Tester.test(), Tester.getCreatorCreator() with remix and solidity 0.4.21

pragma solidity 0.4.21;

contract Creator {
  address creator;

  function Creator() public {
    creator = msg.sender;
  }

  function getCreator() public constant returns(address) {
    return creator;
  }
}

contract Tester {
  Creator creator;
  address creatorCreator;

  function create() public {
    creator = new Creator();
  }

  function test() public {
    creatorCreator = creator.getCreator();
  }
  
  function getCreatorCreator() public constant returns(address) {
    return creatorCreator;
  }
}

Metadata

{"compiler":{"version":"0.4.21+commit.dfe3193c"},"language":"Solidity","output":{"abi":[{"constant":true,"inputs":[],"name":"getCreator","outputs":[{"name":"","type":"address"}],"payable":false,"stateMutability":"view","type":"function"},{"inputs":[],"payable":false,"stateMutability":"nonpayable","type":"constructor"}],"devdoc":{"methods":{}},"userdoc":{"methods":{}}},"settings":{"compilationTarget":{"browser/test_a.sol":"Creator"},"evmVersion":"byzantium","libraries":{},"optimizer":{"enabled":false,"runs":200},"remappings":[]},"sources":{"browser/test_a.sol":{"keccak256":"0x9a4f9f1fc840102efaa24819261ba23d8de8cff9c01377b18d7da47b3d7495aa","urls":["bzzr://4b92b0a80048bc85030318ee5588725839b9e73d83c0cff74392ce358c6b2c59"]}},"version":1}

Geth

Version: 1.8.10-stable
Git Commit: eae63c511ceafab14b92e274c1b18bf1700e2d3d
Architecture: amd64
Protocol Versions: [63 62]
Network Id: 1
Go Version: go1.10
Operating System: linux
GOPATH=
GOROOT=/usr/lib/go-1.10

However, it fails with new versions the solidity, ^0.4.22.

That being said, on Robsten, the following contract ran successfully, but failed when running on the same version of Geth above.

pragma solidity 0.4.24;

contract Creator {
  address creator;

  constructor() public {
    creator = msg.sender;
  }

  function getCreator() public constant returns(address) {
    return creator;
  }
}

contract Tester {
  Creator creator;
  address creatorCreator;

  function create() public {
    creator = new Creator();
  }

  function test() public {
    creatorCreator = creator.getCreator();
  }
  
  function getCreatorCreator() public constant returns(address) {
    return creatorCreator;
  }
}

new Tester(): https://ropsten.etherscan.io/tx/0x731e6abb14cf5fd0d1d5a2f73196d4cab696406b1b1652214aed15a682077fd6
tester.create:
https://ropsten.etherscan.io/tx/0x61b35228b25f69eddc5e5ee1912f616ac066ecf14175126e2a1b021fe0509ce1
tester.test:
https://ropsten.etherscan.io/tx/0x30b21c8bfe94a0e5638033c0e00a7be56a532ba6a6b00b98f2804e422eac7b8c

Metadata

{"compiler":{"version":"0.4.24+commit.e67f0147"},"language":"Solidity","output":{"abi":[{"constant":true,"inputs":[],"name":"getCreator","outputs":[{"name":"","type":"address"}],"payable":false,"stateMutability":"view","type":"function"},{"inputs":[],"payable":false,"stateMutability":"nonpayable","type":"constructor"}],"devdoc":{"methods":{}},"userdoc":{"methods":{}}},"settings":{"compilationTarget":{"browser/test_a.sol":"Creator"},"evmVersion":"byzantium","libraries":{},"optimizer":{"enabled":false,"runs":200},"remappings":[]},"sources":{"browser/test_a.sol":{"keccak256":"0x92900de3747c5d0c79824561230c75bac633b60dbd391520a9f11d7ff7306d67","urls":["bzzr://a552e394c562850513398aea3328dcd0b6d209bcbbd922d07a4a40aea0287f56"]}},"version":1}

chriseth · 2018-06-08T21:40:39Z

My guess would be that this is due to the EVM version not being set to Byzantium on the private chain.

dksuper · 2018-06-09T09:43:07Z

@chriseth So, you mean when I change my EVM version , then problem will be solve?
if that is you mean, then how to change it??

dksuper · 2018-06-09T09:47:36Z

@jeichel-miovision So, what can i do to solve this problem , in geth 1.8.7?

karalabe · 2018-06-11T09:31:03Z

How did you initialize your private chain? The genesis file contains a config field in which you can set the block numbers that forks your occur at. You need to have byzantium enabled for the new EVM features to work on it.

chriseth · 2018-06-11T13:53:30Z

@karalabe would it be possible to default more easily to byzantium somehow?

jeichel-miovision · 2018-06-11T14:30:11Z

Thanks @chriseth the EVM change solved the problem for me.

@dksuper to get my example up and running, I was able it to do it one of two ways.

Specify byzantiumBlock in your genesis.json to enable Byzantium support on your private chain. For my current application, I was able to reinit the entire chain since my private fork is only for testing.

{
    "config": {
        "chainId": 1,
        "homesteadBlock": 0,
        "eip155Block": 0,
        "eip158Block": 0,
        "eip160Block": 0,
        "byzantiumBlock": 0
    },
    "nonce": "0x0000000000000042",
    "timestamp": "0x00",
    "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "extraData": "0x00",
    "gasLimit": "0x8000000",
    "difficulty": "0x100",
    "mixhash": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "coinbase": "0x3333333333333333333333333333333333333333"
}

I substituted an arbitrary choinbase address and arbitrary chainId above. The key is the addition of byzantiumBlock.

If you cannot change the private net and don't want to fork it, you can also use the older compiler version 0.4.21. In my post above, I posted a complete example with the pragma field. I'd recommend solution 1 if you are able. Using older compilers as a workaround may potentially contain undesired bugs, exploits, and missing features that are fixed in newer versions. (That being said newer versions can also contain bugs, exploits, or missing features so when the time comes, test the heck out of your system , lock in the version, and watch forums for exploits and bugs)

dksuper · 2018-06-12T02:43:28Z

@karalabe
Thank you for your reply , i didn't enabled the byzantium in my private chain initialize , because i can't see any information for enabled byzantium , in the go-ethereum README.md , i have two question in follow:

1.If i enabled byzantium in my private chain , then i can use the new versoin compiler to compile my solidity?

2.How to fork in my current private chain? if my current block numbers is 666666 , should i just put 666666 in the byzantiumBlockin field , which is in config field that contains in genesis file, then init it or just run geth?

dksuper · 2018-06-13T08:56:09Z

@jeichel-miovision
Thanks for your reply, do you know how to fork in my current private chain? because i need used old data in current chain

sokun-chorn-webjet · 2018-07-10T06:42:52Z

Appreciate if someone could point out link to wiki page which describes forking private network.

Ugghggh, this has been a nightmare to track down issues, that appear to be related to this. Here's an issue around this: ethereum/go-ethereum#16931

o0ragman0o · 2018-08-29T00:55:13Z

I've solve this issue in my own private chain by including eip150Block: <desired block number> in my genesis config. EIP150 being related to the gas cost adjustment of certain opcodes following a spam attack and which it seems Byzantium EVM is dependant in some way.

{
    "config": {
        "homesteadBlock": 0,
        "eip150Block": 1,
	"byzantiumBlock": 1
    },
    "nonce": "0",
    "difficulty": "0x400",
    "mixhash": "0x00000000000000000000000000000000000000647572616c65787365646c6578",
    "coinbase": "0x0000000000000000000000000000000000000000",
    "timestamp": "0x00",
    "parentHash": "0x0000000000000000000000000000000000000000000000000000000000000000",
    "extraData": "0x",
    "gasLimit": "0x6ACFC0",
    "alloc": {}
}

ligi · 2019-05-21T08:34:08Z

related: #19554

adamschmideg · 2019-05-21T08:35:43Z

Once we are done with the dump config that supports all forks enabled, this is not an issue anymore.

princesinha19 · 2019-06-05T03:58:15Z

I have configured the byzantiumBlock in my private chain then also it is not working. I am using solidity v5.0.0.

dksuper changed the title ~~Always fail in call external contract function~~ Always fail when the contract call external contract Jun 8, 2018

This was referenced Jun 8, 2018

Always fail when the contract call external contract ethereum/solidity#4248

Closed

Contract method not invoked from another contract if it returns value (if compiled by Solidity versions above 0.4.21) ethereum/solidity#4226

Closed

chriseth mentioned this issue Jun 19, 2018

Failed to call an external function of another contract ethereum/solidity#4310

Closed

chriseth mentioned this issue Aug 14, 2018

Contract to contract function call with 0.4.23 ethereum/solidity#4810

Closed

juztin pushed a commit to juztin/docgeth that referenced this issue Aug 15, 2018

Enabling byzantium support, for EVM features...

45edfe2

Ugghggh, this has been a nightmare to track down issues, that appear to be related to this. Here's an issue around this: ethereum/go-ethereum#16931

adamschmideg added status:triage need:documentation labels May 21, 2019

adamschmideg closed this as completed May 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always fail when the contract call external contract #16931

Always fail when the contract call external contract #16931

dksuper commented Jun 8, 2018 •

edited

jeichel-miovision commented Jun 8, 2018 •

edited

jeichel-miovision commented Jun 8, 2018 •

edited

chriseth commented Jun 8, 2018

dksuper commented Jun 9, 2018

dksuper commented Jun 9, 2018

karalabe commented Jun 11, 2018

chriseth commented Jun 11, 2018

jeichel-miovision commented Jun 11, 2018 •

edited

dksuper commented Jun 12, 2018 •

edited

dksuper commented Jun 13, 2018

sokun-chorn-webjet commented Jul 10, 2018

o0ragman0o commented Aug 29, 2018

ligi commented May 21, 2019

adamschmideg commented May 21, 2019

princesinha19 commented Jun 5, 2019

Always fail when the contract call external contract #16931

Always fail when the contract call external contract #16931

Comments

dksuper commented Jun 8, 2018 • edited

System information

Expected behaviour

Actual behaviour

jeichel-miovision commented Jun 8, 2018 • edited

jeichel-miovision commented Jun 8, 2018 • edited

chriseth commented Jun 8, 2018

dksuper commented Jun 9, 2018

dksuper commented Jun 9, 2018

karalabe commented Jun 11, 2018

chriseth commented Jun 11, 2018

jeichel-miovision commented Jun 11, 2018 • edited

dksuper commented Jun 12, 2018 • edited

dksuper commented Jun 13, 2018

sokun-chorn-webjet commented Jul 10, 2018

o0ragman0o commented Aug 29, 2018

ligi commented May 21, 2019

adamschmideg commented May 21, 2019

princesinha19 commented Jun 5, 2019

dksuper commented Jun 8, 2018 •

edited

jeichel-miovision commented Jun 8, 2018 •

edited

jeichel-miovision commented Jun 8, 2018 •

edited

jeichel-miovision commented Jun 11, 2018 •

edited

dksuper commented Jun 12, 2018 •

edited