New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts: unlock multiple accounts fails #1785

Closed
danielnovy opened this Issue Sep 9, 2015 · 6 comments

Comments

Projects
None yet
7 participants
@danielnovy

danielnovy commented Sep 9, 2015

When trying to use --unlock="0 1" geth fails with the message: Fatal: Unlock account failed 'Decryption failed: MAC mismatch'. The first account is unlocked and the message Account '0' unlocked is printed.

It's important to note that unlock="0" AND unlock="1" both works! Also, if you invert the order ("1 0" instead of "0 1"), it prints Account '1' unlocked and then fails to unlock second account with same message. So, the problem is clearly related to unlock multiple accounts and problem always happens on second account.

@obscuren obscuren changed the title from Unlock multiple accounts always fails. to accounts: unlock multiple accounts fails Sep 10, 2015

@obscuren obscuren added the bug label Sep 10, 2015

@obscuren obscuren added this to the 1.3.0 milestone Sep 10, 2015

@obscuren obscuren added I *** labels Sep 22, 2015

@zelig zelig referenced this issue Sep 22, 2015

Merged

console, cli, api fixes #1840

12 of 12 tasks complete

zelig added a commit to ethersphere/go-ethereum that referenced this issue Oct 21, 2015

console:
* lines with leading space are ommitted from history
* exit processed even with whitespace around
* all whitespace lines (not only empty ones) are ignored

add 7 missing commands to admin api autocomplete

registrar: methods now return proper error if reg addresses are not set. fixes ethereum#1457

rpc/console: fix personal.newAccount() regression. Now all comms accept interactive password

registrar: add registrar tests for errors

crypto: catch AES decryption error on presale wallet import + fix error msg format. fixes ethereum#1580

CLI: improve error message when starting a second instance of geth. fixes ethereum#1564

cli/accounts: unlock multiple accounts. fixes ethereum#1785
* make unlocking multiple accounts work with inline <() fd
* passwdfile now correctly read only once
* improve logs
* fix CLI help text for unlocking

fix regression with docRoot / admin API
* docRoot/jspath passed to rpc/api ParseApis, which passes onto adminApi
* docRoot field for JS console in order to pass when RPC is (re)started
* improve flag desc for jspath

common/docserver: catch http errors from response

fix rpc/api tests

common/natspec: fix end to end test (skipped because takes 8s)

registrar: fix major regression:
* deploy registrars on frontier
* register HashsReg and UrlHint in GlobalRegistrar.
* set all 3 contract addresses in code
* zero out addresses first in tests
@zelig

This comment has been minimized.

Show comment
Hide comment
@zelig

zelig Nov 4, 2015

Contributor

I believe this has already been fixed in #1840

Contributor

zelig commented Nov 4, 2015

I believe this has already been fixed in #1840

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Nov 26, 2015

Member

Closing if supposedly fixed. Please reopen if it's not the case. Also note, an upcoming PR will change the account list to comma separated values instead of space separated ones. This is a general move towards eliminating whitespace from within CLI arguments as they cause significant pains when passing through different environments (e.g. bash -> go -> docker -> bash).

Member

karalabe commented Nov 26, 2015

Closing if supposedly fixed. Please reopen if it's not the case. Also note, an upcoming PR will change the account list to comma separated values instead of space separated ones. This is a general move towards eliminating whitespace from within CLI arguments as they cause significant pains when passing through different environments (e.g. bash -> go -> docker -> bash).

@karalabe karalabe closed this Nov 26, 2015

@danielnovy

This comment has been minimized.

Show comment
Hide comment
@danielnovy

danielnovy Nov 26, 2015

Sorry for my late reply! Just tried it now and it's still not working in version 1.4.0-unstable. So, please, reopen the issue since I don't have the privileges to do so. Thanks!

danielnovy commented Nov 26, 2015

Sorry for my late reply! Just tried it now and it's still not working in version 1.4.0-unstable. So, please, reopen the issue since I don't have the privileges to do so. Thanks!

@karalabe karalabe reopened this Nov 26, 2015

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Nov 26, 2015

Member

I'll take a look

Member

karalabe commented Nov 26, 2015

I'll take a look

@fjl fjl self-assigned this Mar 14, 2016

@javgh

This comment has been minimized.

Show comment
Hide comment
@javgh

javgh Mar 17, 2016

I'm also seeing this with geth 1.3.5 - trying to unlock more than one account via --unlock "0 1" fails on whatever account is listed second with a 'Decryption failed: MAC mismatch' error, but only when used in combination with the --password option. When entering the passwords manually, both accounts are unlocked successfully. I'm also only seeing this error on one of my machines - another one also has two accounts and the same geth version and there it works. At the moment I don't see what the difference might be.

javgh commented Mar 17, 2016

I'm also seeing this with geth 1.3.5 - trying to unlock more than one account via --unlock "0 1" fails on whatever account is listed second with a 'Decryption failed: MAC mismatch' error, but only when used in combination with the --password option. When entering the passwords manually, both accounts are unlocked successfully. I'm also only seeing this error on one of my machines - another one also has two accounts and the same geth version and there it works. At the moment I don't see what the difference might be.

@thiagohortal

This comment has been minimized.

Show comment
Hide comment
@thiagohortal

thiagohortal Mar 22, 2016

Hello guys,
I am also getting this return: 'Decryption failed: MAC mismatch', any solution?
I am using web3 project.

Help!

thiagohortal commented Mar 22, 2016

Hello guys,
I am also getting this return: 'Decryption failed: MAC mismatch', any solution?
I am using web3 project.

Help!

@fjl fjl referenced this issue Mar 30, 2016

Merged

accounts: cache key addresses #2284

6 of 6 tasks complete

@obscuren obscuren closed this May 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment