Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth start-up configuration file #2067

Closed
tymat opened this issue Dec 12, 2015 · 3 comments
Closed

geth start-up configuration file #2067

tymat opened this issue Dec 12, 2015 · 3 comments

Comments

@tymat
Copy link

@tymat tymat commented Dec 12, 2015

Would be nice to have a configuration file that has the various geth command line parameters (JSON, yaml, ini, dotfile, etc...). Today we get around this by creating a shell script but it would be nice to have something better for automated deploys of geth nodes.

geth --config ~/.ethereum/geth.[json,yaml,ini,etc.]
@obscuren
Copy link
Member

@obscuren obscuren commented Jan 4, 2016

This will not be implemented for numerous reason and one of them is maintenance. Configuration files tend to bite people in the ass and therefor we'd rather not see it implemented.

I don't think .sh files are that bad tho, they are actually rather nice and feedback is given when a bad configuration parameter is being used.

@pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Nov 24, 2016

I would like to petition/request that this be reconsidered as a feature.

@obscuren you say that they tend to bite people in the ass. I don't see why the implementation of a config file cannot be done so that it protects people from the common pitfalls.

  1. If a config value is present in the file that doesn't map to one of the allowed options display a warning or throw an error.
  2. At startup, if a config file was found or used, print out a message indicating as much: "Loaded configuration options /path/to/config.something"

As for maintenance overhead, it has been almost a year since this was first proposed. I understand there is overhead here, but configuration via config file is extremely common and geth has matured a lot in the last 10 months.

@fjl
Copy link
Contributor

@fjl fjl commented Sep 25, 2017

Added in #13875, released in 1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants