Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for events in Go bindings #2792

Closed
murrekatt opened this Issue Jul 8, 2016 · 18 comments

Comments

Projects
None yet
@murrekatt
Copy link

murrekatt commented Jul 8, 2016

It would be great to have support for events in the Go bindings to easily watch needed events.

In the docs it is only mentioned it is waiting for some RPC pub/sub changes but maybe these are already available?

Is this feature being worked on or discussed?

I am aware it is possible to get logs and thus events either with polling or subscription over JSON RPC.

@karalabe

This comment has been minimized.

Copy link
Member

karalabe commented Jul 12, 2016

It's waiting for a new RPC client implementation from @fjl . When that is merged in, we can properly use subscriptions to get the event logs and I can finally implement this for Native DApps :)

@murrekatt

This comment has been minimized.

Copy link
Author

murrekatt commented Jul 18, 2016

@karalabe @fjl any schedule for this or place to follow/discuss the work?

@fjl

This comment has been minimized.

Copy link
Contributor

fjl commented Jul 18, 2016

The RPC client is currently in review, see #2808. We are also reworking filter system internals to provide
a uniform API for subscriptions (in #2798).

When those two are in, the abigen backend package will need to be updated with subscription support.
This won't be much work. If everything goes well, I'd say you have to wait two more weeks.

@fjl

This comment has been minimized.

Copy link
Contributor

fjl commented Aug 17, 2016

See #2900

@fjl fjl added the in progress label Aug 17, 2016

@fjl fjl added this to the 1.5.0 milestone Aug 17, 2016

@johnweldon

This comment has been minimized.

Copy link

johnweldon commented Sep 15, 2016

I see

  • #2900 was closed, and apparently not replaced.
  • #2798 was closed in favour of #2885 and merged.
  • #2808 was merged.

What remains? Just abigen updates? I don't see an abigen issue addressing events (other than this one).

@fjl

This comment has been minimized.

Copy link
Contributor

fjl commented Sep 15, 2016

This issue is still open, the work is not done yet. @awishformore told me he is still working on this. If he isn't, me or @karalabe will step in and do it. Either way this is part of the 1.5 milestone and we all want it, so it'll happen.

@awishformore

This comment has been minimized.

Copy link

awishformore commented Sep 21, 2016

I will start working on this again this weekend. Had a couple of rough weeks.

@fjl fjl modified the milestones: 1.6.0, 1.5.0 Nov 15, 2016

@markya0616

This comment has been minimized.

Copy link
Contributor

markya0616 commented Jan 20, 2017

Any updates about this PR? We really need this feature! Thanks.

@awishformore

This comment has been minimized.

Copy link

awishformore commented Jan 22, 2017

I dropped the ball on this one, just couldn't find the time anymore. Not sure on the current status.

@alanchchen

This comment has been minimized.

Copy link
Contributor

alanchchen commented Jan 25, 2017

@karalabe, @fjl
Any update about this feature?
Not sure if there is something I can do but I'm willing to help this.

@karalabe karalabe modified the milestones: 1.6.1, 1.6.0 Apr 13, 2017

@coreyog

This comment has been minimized.

Copy link

coreyog commented Jun 20, 2017

Is this expected to be out in 1.6.6 1.6.7 1.6.8? We're multiple versions ahead of the target milestone of this issue.

@fjl fjl self-assigned this Aug 4, 2017

@fjl fjl modified the milestones: 1.7.0, 1.6.1 Aug 4, 2017

@robert-zaremba

This comment has been minimized.

Copy link
Contributor

robert-zaremba commented Sep 4, 2017

Is there any workaround for this? How can I get the events in Go without waiting for this release?

@fjl

This comment has been minimized.

Copy link
Contributor

fjl commented Sep 10, 2017

Work to add event decoding is going on in #14743

@murrekatt

This comment has been minimized.

Copy link
Author

murrekatt commented Dec 6, 2017

@fjl @karalabe what's the status of this? I see 1.7.0 is the milestone and that is already released. Thanks for an update!

@lewgun

This comment has been minimized.

Copy link

lewgun commented Feb 9, 2018

@fjl @karalabe what's the status of this? Thanks for an update!

@karalabe

This comment has been minimized.

Copy link
Member

karalabe commented Feb 9, 2018

@paultiplady

This comment has been minimized.

Copy link

paultiplady commented Feb 15, 2018

I just spent a while digging around for docs on this new feature, so in case it's useful to anyone else on this thread, here's a good writeup of the new abigen features for filtering/watching events:

#15832

🙏 many thanks @karalabe

@karalabe

This comment has been minimized.

Copy link
Member

karalabe commented Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.