Skip to content

Conversation

@nnn-gif
Copy link
Contributor

@nnn-gif nnn-gif commented Apr 24, 2017

issue #14356

@GitCop
Copy link

GitCop commented Apr 24, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: f0cbd4e
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@nnn-gif nnn-gif changed the title update readme for correct genesis.json README : correct genesis.json Apr 24, 2017
@fjl fjl changed the title README : correct genesis.json README: add config to genesis.json May 3, 2017
@fjl fjl merged commit c3dc01c into ethereum:master May 3, 2017
```json
{
"config": {
"chainId": 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think chainid can or should be zero. @fjl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants