Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/swarm: Add --httpaddr flag #14475

Merged
merged 1 commit into from May 22, 2017

Conversation

@lmars
Copy link
Contributor

commented May 15, 2017

Fixes #14474.

EnsRoot common.Address
NetworkId uint64
Path string
ListenAddr string

This comment has been minimized.

Copy link
@zelig

zelig May 15, 2017

Contributor

so you need to add this to the config tests with the default value, it fails the CI test https://travis-ci.org/ethereum/go-ethereum/jobs/232519067#L1592

This comment has been minimized.

Copy link
@lmars

lmars May 15, 2017

Author Contributor

Fixed in c1da402.

@zelig zelig added this to the 1.6.2 milestone May 15, 2017

@lmars lmars force-pushed the ethersphere:swarm-listen-address branch from 7e01c9f to c1da402 May 15, 2017

@homotopycolimit

This comment has been minimized.

Copy link
Contributor

commented May 15, 2017

Maybe the flag should have a different name. The word 'address' is a little overloaded and bzzaddr sounds like it could be the swarm address of the node.

In many servers and daemons the corresponding value is called --listen or --listenaddress; maybe we could use that. Or otherwise maybe --http-address ?

just a thought.

cmd/swarm: Add --httpaddr flag
Fixes #14474.

Signed-off-by: Lewis Marshall <lewis@lmars.net>

@lmars lmars force-pushed the ethersphere:swarm-listen-address branch from c1da402 to 1ea43ec May 17, 2017

@lmars

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2017

@zelig @homotopycolimit I have renamed to --httpaddr.

@lmars lmars changed the title cmd/swarm: Add --bzzaddr flag cmd/swarm: Add --httpaddr flag May 17, 2017

@zelig
zelig approved these changes May 17, 2017

@obscuren obscuren merged commit 4a2c17b into ethereum:master May 22, 2017

3 checks passed

commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gbalint gbalint deleted the ethersphere:swarm-listen-address branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.