New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: implement ChainIndexer #14522

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
4 participants
@zsfelfoldi
Contributor

zsfelfoldi commented May 26, 2017

This PR is an alternative version of #14431 that only uses the event system for updating sections and does not use the chain mutex or modify BlockChain/HeaderChain/LightChain at all.
A rebased version of the bloombits filter can be found on the https://github.com/zsfelfoldi/go-ethereum/commits/bloombits2 branch.

@zsfelfoldi zsfelfoldi requested review from fjl and Arachnid May 26, 2017

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe May 26, 2017

Member

I would really really like to see thorough tests on any new stuff added to core.

Member

karalabe commented May 26, 2017

I would really really like to see thorough tests on any new stuff added to core.

@zsfelfoldi

This comment has been minimized.

Show comment
Hide comment
@zsfelfoldi

zsfelfoldi May 28, 2017

Contributor

@karalabe you are right, although this is not consensus stuff and could be placed in any package but it deserves a test so I added one. Also, it found problems in some corner cases which I have fixed now :)

Contributor

zsfelfoldi commented May 28, 2017

@karalabe you are right, although this is not consensus stuff and could be placed in any package but it deserves a test so I added one. Also, it found problems in some corner cases which I have fixed now :)

@zsfelfoldi zsfelfoldi requested a review from karalabe May 28, 2017

@fjl fjl modified the milestone: 1.6.3 May 31, 2017

@karalabe karalabe modified the milestones: 1.6.4, 1.6.3 Jun 1, 2017

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Jun 14, 2017

Member

Uhm, @zsfelfoldi you did see that all the tests failed, right?

Member

karalabe commented Jun 14, 2017

Uhm, @zsfelfoldi you did see that all the tests failed, right?

@Arachnid

This comment has been minimized.

Show comment
Hide comment
@Arachnid

Arachnid Jun 15, 2017

Contributor

@karalabe It looks like that was just timeouts?

Contributor

Arachnid commented Jun 15, 2017

@karalabe It looks like that was just timeouts?

Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go
Show outdated Hide outdated core/chain_indexer.go

@fjl fjl modified the milestones: 1.6.7, 1.7.0 Jul 17, 2017

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Aug 3, 2017

Member

@Arachnid PTAL, we've polished up the PR a bit, it's ready from my perspective. More exhaustive tests would be nice, but let's build on top and test, not hold it off.

Member

karalabe commented Aug 3, 2017

@Arachnid PTAL, we've polished up the PR a bit, it's ready from my perspective. More exhaustive tests would be nice, but let's build on top and test, not hold it off.

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@ethereum ethereum deleted a comment from GitCop Aug 5, 2017

@fjl

fjl approved these changes Aug 8, 2017

@fjl fjl merged commit 374c49e into ethereum:master Aug 8, 2017

3 checks passed

commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment