New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Added support for downloading to another DB instance #14785

Merged
merged 2 commits into from Oct 11, 2017

Conversation

Projects
None yet
5 participants
@Arachnid
Contributor

Arachnid commented Jul 10, 2017

No description provided.

@Arachnid Arachnid requested review from karalabe and fjl Jul 10, 2017

@fjl

Still need to try it, but code looks simple enough.

Show outdated Hide outdated cmd/geth/chaincmd.go Outdated
@GitCop

This comment has been minimized.

Show comment
Hide comment
@GitCop

GitCop Sep 7, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: f4af32e
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

GitCop commented Sep 7, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: f4af32e
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

@holiman

If I'm reading it right, this is a very non-invasive change, which shouldn't affect any existing functionality.

utils.DataDirFlag,
utils.CacheFlag,
utils.SyncModeFlag,
utils.FakePoWFlag,

This comment has been minimized.

@karalabe

karalabe Oct 10, 2017

Member

I think we're going to need

			utils.TestnetFlag,
			utils.RinkebyFlag,

too to allow copying over the testnet chains.

@karalabe

karalabe Oct 10, 2017

Member

I think we're going to need

			utils.TestnetFlag,
			utils.RinkebyFlag,

too to allow copying over the testnet chains.

Show outdated Hide outdated cmd/geth/chaincmd.go Outdated

Arachnid and others added some commits Jul 10, 2017

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Oct 10, 2017

Member

I've moved the localPeer into downloader.FakePeer so it may be reused by other code too if need be (also it was an annoyingly large chunk of code inside cmd/geth/chaincmd.go). The last commit also fixes a small issue where PoA chains couldn't be copied due to utils.MakeChain always picking ethash.

@Arachnid @fjl @holiman PTAL

Member

karalabe commented Oct 10, 2017

I've moved the localPeer into downloader.FakePeer so it may be reused by other code too if need be (also it was an annoyingly large chunk of code inside cmd/geth/chaincmd.go). The last commit also fixes a small issue where PoA chains couldn't be copied due to utils.MakeChain always picking ethash.

@Arachnid @fjl @holiman PTAL

@karalabe karalabe added this to the 1.7.2 milestone Oct 10, 2017

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Oct 10, 2017

Member

It's LGTM from me and @Arachnid. But since it's a combo PR, @fjl or @holiman please thumb it up once again.

Member

karalabe commented Oct 10, 2017

It's LGTM from me and @Arachnid. But since it's a combo PR, @fjl or @holiman please thumb it up once again.

@holiman

LGTM

@karalabe karalabe merged commit ad44475 into ethereum:master Oct 11, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment