New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Use EIP155Signer - closes #14762 #14817

Merged
merged 2 commits into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@ligi
Member

ligi commented Jul 16, 2017

This might be horribly wrong - but it compiles - feedback welcome - mainly want to push #14762 ;-)

Show outdated Hide outdated mobile/types.go
@GitCop

This comment has been minimized.

Show comment
Hide comment
@GitCop

GitCop Jul 17, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: b56f2f1
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

GitCop commented Jul 17, 2017

Thank you for your contribution! Your commits seem to not adhere to the repository coding standards

  • Commit: b56f2f1
  • Commits must be prefixed with the package(s) they modify

Please check the contribution guidelines for more details.


This message was auto-generated by https://gitcop.com

Show outdated Hide outdated mobile/types.go
@karalabe

LGTM

@karalabe karalabe added this to the 1.7.0 milestone Jul 17, 2017

@karalabe karalabe merged commit cf5d4b5 into ethereum:master Jul 17, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

markya0616 added a commit to markya0616/go-ethereum that referenced this pull request Aug 17, 2017

mobile: use EIP155 signer (ethereum#14817)
* mobile: Use EIP155Signer - closes ethereum#14762

* mobile: Correctly fall back on HomesteadSigner when no chainID is passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment