New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/vm, crypto/bn256: fix bn256 use and pairing corner case #14993

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@karalabe
Member

karalabe commented Aug 17, 2017

No description provided.

@karalabe karalabe requested a review from holiman Aug 17, 2017

@karalabe karalabe added this to the 1.7.0 milestone Aug 17, 2017

@karalabe karalabe added the metropolis label Aug 17, 2017

new_e := miller(b[i].p, a[i].p, pool)
e.Mul(e, new_e, pool)
if a[i].p.IsInfinity() || b[i].p.IsInfinity() {
continue

This comment has been minimized.

@holiman

holiman Aug 17, 2017

Contributor

Do we have a consensus-test which goes through this code path ?

@holiman

holiman Aug 17, 2017

Contributor

Do we have a consensus-test which goes through this code path ?

This comment has been minimized.

@karalabe

karalabe Aug 17, 2017

Member

Yes, 3 tests fail without this fix.

@karalabe

karalabe Aug 17, 2017

Member

Yes, 3 tests fail without this fix.

@karalabe karalabe merged commit 104375f into ethereum:master Aug 17, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
commit-message-check/gitcop All commit messages are valid
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment