Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
consensus, core, tests: implement Metropolis EIP 649 #15028
The PR also pulls in the latest test suite, which among other throws out explicit log validation to implicit one via RLP(logs).
Note, some tests are failing because the consensus test suite was only partially updated to the new log format, so the non-updated ones cannot be parsed. I'll keep checking the test suite to see if there are updates to fix them.
This was already here, not new for this PR: https://github.com/ethereum/go-ethereum/pull/15028/files#diff-e226000964244889df127e5b44dbf192R546 :
r.Div(blockReward, big32) reward.Add(reward, r)
Looks un-intuitive (reusing
@karalabe I noticed that the
Is this on purpose?