New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, dashboard: use webpack dev server, remove custom assets #16263

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@kurkomisi
Contributor

kurkomisi commented Mar 6, 2018

  • use yarn instead of npm (comparison)
  • use webpack-dev-server instead of geth serving custom resources
  • throw out Assets config from geth
  • change KB to KiB in CustomTooltip (explanation)
  • change message structure
  • change chart tooltip descriptions meaningfully
  • use link to commit hash
  • use intuitive menu icon
  • define yarn scripts
Show outdated Hide outdated .gitignore
@karalabe

LGTM!

@karalabe karalabe merged commit 704840a into ethereum:master Mar 8, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

prestonvanloon added a commit to prestonvanloon/go-ethereum that referenced this pull request Apr 2, 2018

cmd, dashboard: use webpack dev server, remove custom assets (#16263)
* cmd, dashboard: remove custom assets, webpack dev server

* dashboard: yarn commands, small fixes

hackmod pushed a commit to OpenCommunityCoin/go-esn that referenced this pull request Jul 9, 2018

cmd, dashboard: use webpack dev server, remove custom assets (#16263)
* cmd, dashboard: remove custom assets, webpack dev server

* dashboard: yarn commands, small fixes

mariameda added a commit to NiluPlatform/go-nilu that referenced this pull request Aug 23, 2018

cmd, dashboard: use webpack dev server, remove custom assets (#16263)
* cmd, dashboard: remove custom assets, webpack dev server

* dashboard: yarn commands, small fixes

firmianavan added a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018

cmd, dashboard: use webpack dev server, remove custom assets (#16263)
* cmd, dashboard: remove custom assets, webpack dev server

* dashboard: yarn commands, small fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment