cmd/evm: use block number from genesis #16569
Merged
Conversation
fjl
changed the title
|
Almost |
cmd/evm/runner.go
Outdated
| GasLimit: initialGas, | ||
| GasPrice: utils.GlobalBig(ctx, PriceFlag.Name), | ||
| Value: utils.GlobalBig(ctx, ValueFlag.Name), | ||
| BlockNumber: big.NewInt(0).SetUint64(blockNumber), |
karalabe
May 2, 2018
Member
big.NewInt(0) -> new(big.Int)
big.NewInt(0) -> new(big.Int)
cmd/evm/runner.go
Outdated
| @@ -27,6 +27,8 @@ import ( | |||
|
|
|||
| goruntime "runtime" | |||
|
|
|||
| "math/big" | |||
|
|
|||
karalabe
May 2, 2018
Member
Please delete all newlines form the imports and run goimports again, it will reorder these a bit.
Please delete all newlines form the imports and run goimports again, it will reorder these a bit.
|
Thanks, done! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR adds support to
evmto use blocknumber from genesis, if provided.