Skip to content

cmd/evm: use block number from genesis - #16569

Merged
karalabe merged 1 commit into
ethereum:masterfrom
holiman:evm_blocknum
May 2, 2018
Merged

cmd/evm: use block number from genesis#16569
karalabe merged 1 commit into
ethereum:masterfrom
holiman:evm_blocknum

Conversation

@holiman

@holiman holiman commented Apr 26, 2018

Copy link
Copy Markdown
Contributor

This PR adds support to evm to use blocknumber from genesis, if provided.

@fjl fjl changed the title evm/main: use blocknumber from genesis cmd/evm: use block number from genesis Apr 26, 2018

@karalabe karalabe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost

Comment thread cmd/evm/runner.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big.NewInt(0) -> new(big.Int)

Comment thread cmd/evm/runner.go Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete all newlines form the imports and run goimports again, it will reorder these a bit.

@karalabe karalabe added this to the 1.8.7 milestone May 2, 2018
@holiman

holiman commented May 2, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, done!

@karalabe karalabe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe
karalabe merged commit 5449139 into ethereum:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants