Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upcmd/evm: use block number from genesis #16569
+10
−7
Conversation
fjl
changed the title from
evm/main: use blocknumber from genesis
to
cmd/evm: use block number from genesis
Apr 26, 2018
cmd/evm/runner.go
Outdated
| GasLimit: initialGas, | ||
| GasPrice: utils.GlobalBig(ctx, PriceFlag.Name), | ||
| Value: utils.GlobalBig(ctx, ValueFlag.Name), | ||
| BlockNumber: big.NewInt(0).SetUint64(blockNumber), |
This comment has been minimized.
This comment has been minimized.
cmd/evm/runner.go
Outdated
| @@ -27,6 +27,8 @@ import ( | ||
| goruntime "runtime" | ||
| "math/big" | ||
This comment has been minimized.
This comment has been minimized.
karalabe
May 2, 2018
Member
Please delete all newlines form the imports and run goimports again, it will reorder these a bit.
karalabe
added this to the 1.8.7 milestone
May 2, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks, done! |
karalabe
merged commit 5449139
into
ethereum:master
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
holiman commentedApr 26, 2018
This PR adds support to
evmto use blocknumber from genesis, if provided.