Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/evm: use block number from genesis #16569

Merged
merged 1 commit into from May 2, 2018
Merged

Conversation

@holiman
Copy link
Contributor

@holiman holiman commented Apr 26, 2018

This PR adds support to evm to use blocknumber from genesis, if provided.

@fjl fjl changed the title evm/main: use blocknumber from genesis cmd/evm: use block number from genesis Apr 26, 2018
@holiman holiman force-pushed the holiman:evm_blocknum branch from e7370f7 to 2a9de8c May 2, 2018
Copy link
Member

@karalabe karalabe left a comment

Almost

GasLimit: initialGas,
GasPrice: utils.GlobalBig(ctx, PriceFlag.Name),
Value: utils.GlobalBig(ctx, ValueFlag.Name),
BlockNumber: big.NewInt(0).SetUint64(blockNumber),

This comment has been minimized.

@karalabe

karalabe May 2, 2018
Member

big.NewInt(0) -> new(big.Int)

@@ -27,6 +27,8 @@ import (

goruntime "runtime"

"math/big"

This comment has been minimized.

@karalabe

karalabe May 2, 2018
Member

Please delete all newlines form the imports and run goimports again, it will reorder these a bit.

@karalabe karalabe added this to the 1.8.7 milestone May 2, 2018
@holiman holiman force-pushed the holiman:evm_blocknum branch from 2a9de8c to 8dfa4f4 May 2, 2018
@holiman
Copy link
Contributor Author

@holiman holiman commented May 2, 2018

Thanks, done!

Copy link
Member

@karalabe karalabe left a comment

LGTM

@karalabe karalabe merged commit 5449139 into ethereum:master May 2, 2018
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
commit-message-check/gitcop All commit messages are valid
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants