Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/puppeth: Accept ssh identity in the server string #17407

Merged
merged 2 commits into from Aug 20, 2018

Conversation

nileshtrivedi
Copy link
Contributor

This should fix #15532 .

Server string can now be in this format: username:identity@hostname:port. Only hostname is mandatory. We now fall back to username = current system username, identity = id_rsa and port = 22.

This allows the user to specify a different SSH identity file for each server and persist it.

The entire server string is returned as a label because I couldn't find the rationale for current behavior which seems over-complicated.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I really like the idea of adding the identity file there!

@karalabe karalabe added this to the 1.8.14 milestone Aug 20, 2018
@karalabe karalabe merged commit 7d38d53 into ethereum:master Aug 20, 2018
firmianavan pushed a commit to firmianavan/go-ethereum that referenced this pull request Aug 28, 2018
* cmd/puppeth: Accept identityfile in the server string with fallback to id_rsa

* cmd/puppeth: code polishes + fix heath check double ports
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* cmd/puppeth: Accept identityfile in the server string with fallback to id_rsa

* cmd/puppeth: code polishes + fix heath check double ports
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* cmd/puppeth: Accept identityfile in the server string with fallback to id_rsa

* cmd/puppeth: code polishes + fix heath check double ports
cryptomental pushed a commit to cryptomental/go-ethereum that referenced this pull request Jan 9, 2019
* cmd/puppeth: Accept identityfile in the server string with fallback to id_rsa

* cmd/puppeth: code polishes + fix heath check double ports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set puppeth ssh deployment key
2 participants