Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR for the v1.8.24 maintenance release #19370

Merged
merged 11 commits into from Apr 8, 2019

Conversation

Projects
None yet
4 participants
@karalabe
Copy link
Member

commented Apr 2, 2019

See release notes.

@karalabe karalabe requested a review from zsfelfoldi as a code owner Apr 2, 2019

@karalabe karalabe requested a review from holiman as a code owner Apr 8, 2019

@holiman

holiman approved these changes Apr 8, 2019

Copy link
Contributor

left a comment

LGTM so far

holiman and others added some commits Apr 2, 2019

all: simplify timestamps to uint64 (#19372)
* all: simplify timestamps to uint64

* tests: update definitions

* clef, faucet, mobile: leftover uint64 fixups

* ethash: fix tests

* graphql: update schema for timestamp

* ethash: remove unused variable

@karalabe karalabe force-pushed the karalabe:geth-1.8.24 branch from 3934719 to 442320a Apr 8, 2019

rjl493456442 and others added some commits Dec 17, 2018

p2p/discover: bump failure counter only if no nodes were provided (#1…
…9362)

This resolves a minor issue where neighbors responses containing less
than 16 nodes would bump the failure counter, removing the node. One
situation where this can happen is a private deployment where the total
number of extant nodes is less than 16.

Issue found by @Jsying.
eth, les, geth: implement cli-configurable global gas cap for RPC cal…
…ls (#19401)

* eth, les, geth: implement cli-configurable global gas cap for RPC calls

* graphql, ethapi: place gas cap in DoCall

* ethapi: reformat log message

@karalabe karalabe requested a review from fjl as a code owner Apr 8, 2019

@karalabe karalabe merged commit 4e13a09 into ethereum:release/1.8 Apr 8, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.