Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth, internal, node, vendor: nuke geth monitor #19399

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@karalabe
Copy link
Member

commented Apr 5, 2019

This PR nukes the old Geth monitor along with it's dependencies. It also updates a few dependencies that govendor messed up while removing the monitor ones. Figured there's no harm if we bump a few to include 2 years' worth of polishes.

@karalabe karalabe added this to the 1.9.0 milestone Apr 5, 2019

@karalabe karalabe force-pushed the karalabe:nuke-monitor branch from 2b13a01 to 29bc982 Apr 5, 2019

@holiman

holiman approved these changes Apr 5, 2019

Copy link
Contributor

left a comment

LGTM!

@karalabe karalabe merged commit ee376f6 into ethereum:master Apr 5, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.