Skip to content

internal/ethapi: estimate gas usage automatically.#19508

Merged
karalabe merged 1 commit intoethereum:masterfrom
rjl493456442:estimate-gas
Apr 30, 2019
Merged

internal/ethapi: estimate gas usage automatically.#19508
karalabe merged 1 commit intoethereum:masterfrom
rjl493456442:estimate-gas

Conversation

@rjl493456442
Copy link
Member

@rjl493456442 rjl493456442 commented Apr 29, 2019

This PR introduces functionality to enable gas estimation for transaction signing or sending.

Currently, the gas is not specified, then geth will use a hardcoded value(90k) as the default gas value. In this PR, geth will use EstimateGas function instead.

Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants