Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/devp2p: fix flakey SameRequestID test #22754

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

renaynay
Copy link
Contributor

@renaynay renaynay commented Apr 27, 2021

This PR fixes an issue with the SameRequestID test in the eth test suite that caused it to be flakey both in the CI and when run on hive.

@renaynay renaynay marked this pull request as ready for review April 28, 2021 12:21
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.10.3 milestone Apr 28, 2021
@holiman holiman merged commit e4270ca into ethereum:master Apr 28, 2021
@renaynay renaynay deleted the ethtest-fix-flakeySameReqID branch April 28, 2021 20:25
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants