Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less allocation of big int during for loop in ethash #23199

Merged
merged 1 commit into from Jul 28, 2021

Conversation

@fxfactorial
Copy link
Contributor

@fxfactorial fxfactorial commented Jul 13, 2021

No description provided.

@fxfactorial fxfactorial requested a review from karalabe as a code owner Jul 13, 2021
@fxfactorial fxfactorial changed the title less allocation of big int during for loop in miner less allocation of big int during for loop in ethash Jul 13, 2021
Copy link
Contributor

@holiman holiman left a comment

LGTM

@fxfactorial
Copy link
Contributor Author

@fxfactorial fxfactorial commented Jul 24, 2021

Since approved , can we merge ? @karalabe

@holiman holiman merged commit 0730acc into ethereum:master Jul 28, 2021
1 of 2 checks passed
@holiman holiman added this to the 1.10.7 milestone Jul 28, 2021
@fxfactorial fxfactorial deleted the less-alloc branch Jul 28, 2021
sidhujag added a commit to sidhujag/go-ethereum that referenced this issue Jul 28, 2021
reds pushed a commit to reds/go-ethereum that referenced this issue Aug 28, 2021
i-norden added a commit to vulcanize/go-ethereum that referenced this issue Sep 10, 2021
atif-konasl added a commit to lukso-network/pandora-execution-engine that referenced this issue Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants