Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd, core, eth, miner: deprecate miner.gastarget flag #23213

Merged
merged 1 commit into from Aug 10, 2021

Conversation

@rjl493456442
Copy link
Contributor

@rjl493456442 rjl493456442 commented Jul 15, 2021

Fixes #23170

This PR simplifies the gas adjustment mechanism a bit and also drop the miner.gastarget flag support.
Note the CLI flag(--miner.gastarget) and the config field(miner.gasFloor) are still kept for backward compatibility.

@holiman
Copy link
Contributor

@holiman holiman commented Aug 2, 2021

So, if 1559 is not active, how will the 'simplified' algorithm behave? Previously, it decayed until the floor, unless the usage was above certain threshold, in which case it increased up to a max. The simplified form here -- I guess it just always targets the upper bound?

Copy link
Contributor

@holiman holiman left a comment

LGTM

Copy link
Member

@karalabe karalabe left a comment

SGTM

@karalabe karalabe added this to the 1.10.7 milestone Aug 10, 2021
@karalabe karalabe merged commit 6d17546 into ethereum:master Aug 10, 2021
2 checks passed
reds pushed a commit to reds/go-ethereum that referenced this issue Aug 28, 2021
i-norden added a commit to vulcanize/go-ethereum that referenced this issue Sep 10, 2021
atif-konasl added a commit to lukso-network/pandora-execution-engine that referenced this issue Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants