Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/utils: add --nousb to the list of deprecated flags #23388

Merged
merged 5 commits into from Aug 17, 2021

Conversation

@Zachinquarantine
Copy link
Contributor

@Zachinquarantine Zachinquarantine commented Aug 12, 2021

This adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.

@Zachinquarantine
Copy link
Contributor Author

@Zachinquarantine Zachinquarantine commented Aug 12, 2021

I hate this goimports error. There's nothing wrong with the syntax on that line, and yet it thinks there's a space where there's not.

@karalabe
Copy link
Member

@karalabe karalabe commented Aug 13, 2021

You should configure your editor to run gofmt or goimports on save. That's how all of us do it. You won't be able to manually fix these, Go is very strongly "formatted".

The reason it's complaining is because there's a trailing tab (whitespace) after the } at the specified line.

@Zachinquarantine
Copy link
Contributor Author

@Zachinquarantine Zachinquarantine commented Aug 13, 2021

You should configure your editor to run gofmt or goimports on save. That's how all of us do it. You won't be able to manually fix these, Go is very strongly "formatted".

The reason it's complaining is because there's a trailing tab (whitespace) after the } at the specified line.

alright, I've got my vscode configured to run gofmt now, so this commit should pass

@Zachinquarantine
Copy link
Contributor Author

@Zachinquarantine Zachinquarantine commented Aug 13, 2021

@karalabe alright, it passed on Travis, where it's required to pass

@Zachinquarantine
Copy link
Contributor Author

@Zachinquarantine Zachinquarantine commented Aug 13, 2021

from what I can see, appveyor failed because it didn't like the UDP tests, which I didn't even touch
slika

Copy link
Contributor

@holiman holiman left a comment

LGTM, thanks

@holiman holiman merged commit 16ecdd5 into ethereum:master Aug 17, 2021
1 of 2 checks passed
@holiman holiman added this to the 1.10.8 milestone Aug 17, 2021
@Zachinquarantine Zachinquarantine deleted the showdeprecatedflags branch Aug 17, 2021
sidhujag added a commit to sidhujag/go-ethereum that referenced this issue Aug 18, 2021
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
reds pushed a commit to reds/go-ethereum that referenced this issue Aug 28, 2021
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
i-norden added a commit to vulcanize/go-ethereum that referenced this issue Sep 10, 2021
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
atif-konasl added a commit to lukso-network/pandora-execution-engine that referenced this issue Oct 15, 2021
Adds --nousb as a deprecated flag when someone runs the geth show-deprecated-flags command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants