Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signer/core/apitypes: fix issue in complex typed data signing #24220

Merged
merged 1 commit into from Feb 8, 2022

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Jan 10, 2022

This is a rebased version of #24102.
Looks good to me (I'm not the author)

@fjl fjl changed the title signer/core: fix complex typed data signing (EIP-712) signer/core/apitypes: fix issue in complex typed data signing Feb 8, 2022
@holiman holiman self-assigned this Feb 8, 2022
@pranksteess
Copy link
Contributor

pranksteess commented Feb 8, 2022

Thanks, let's do it

@holiman
Copy link
Contributor Author

holiman commented Feb 8, 2022

@fjl rebased, can you please 👍 ?

fjl
fjl approved these changes Feb 8, 2022
@holiman holiman added this to the 1.10.16 milestone Feb 8, 2022
@holiman holiman merged commit 5a0d487 into ethereum:master Feb 8, 2022
1 check passed
@holiman holiman deleted the fix_712 branch Feb 8, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this issue Feb 11, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
and00999 pushed a commit to and00999/go-ethereum that referenced this issue Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants