Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove un-necessary comment describing un-used parameter fullTx #24271

Merged
merged 1 commit into from Jan 24, 2022

Conversation

aeharvlee
Copy link
Contributor

@aeharvlee aeharvlee commented Jan 22, 2022

Because there is no fullTx parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.

Because there is no `fullTx` parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.
Copy link
Member

@karalabe karalabe left a comment

Thank you!

@karalabe karalabe added this to the 1.10.16 milestone Jan 24, 2022
@karalabe karalabe merged commit 06e16de into ethereum:master Jan 24, 2022
1 check passed
ValentinTrinque pushed a commit to vegaprotocol/go-ethereum that referenced this pull request Jan 25, 2022
Because there is no `fullTx` parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.
MariusVanDerWijden pushed a commit to MariusVanDerWijden/go-ethereum that referenced this pull request Jan 27, 2022
Because there is no `fullTx` parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Jan 28, 2022
Because there is no `fullTx` parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
Because there is no `fullTx` parameter at function signatures and
uncle apis does not return txs also, those lines are un-necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants