Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: fix incorrect type on empty slice #24372

Merged
merged 2 commits into from Feb 15, 2022

Conversation

0x6f736f646f
Copy link
Contributor

@0x6f736f646f 0x6f736f646f commented Feb 11, 2022

Signed-off-by: 0x6f736f646f blackd0t@protonmail.com

Resolves #24368

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>
Copy link
Contributor

@s1na s1na left a comment

Looks good, only one nit

@@ -88,6 +88,7 @@ type feeHistoryResult struct {
GasUsedRatio []float64 `json:"gasUsedRatio"`
}

// FeeHistory function
Copy link
Contributor

@s1na s1na Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you added a comment, but it's not a very helpful one

Copy link
Contributor

@holiman holiman Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this or write something sensible

Copy link
Contributor

@holiman holiman Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, I fixed it

Copy link
Contributor

@holiman holiman left a comment

LGTM aside from the stray comment

@@ -88,6 +88,7 @@ type feeHistoryResult struct {
GasUsedRatio []float64 `json:"gasUsedRatio"`
}

// FeeHistory function
Copy link
Contributor

@holiman holiman Feb 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this or write something sensible

internal/ethapi/api.go Outdated Show resolved Hide resolved
@holiman holiman changed the title Fixes fields["logs"] incorrectly set internal/ethapi: fix incorrect type on empty slice Feb 15, 2022
@holiman holiman added this to the 1.10.16 milestone Feb 15, 2022
@holiman holiman merged commit f01e2fa into ethereum:master Feb 15, 2022
1 check was pending
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Feb 15, 2022
* Fixes ethereum#24368

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>

* Update internal/ethapi/api.go

Co-authored-by: Martin Holst Swende <martin@swende.se>
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this pull request May 26, 2022
* Fixes ethereum#24368

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>

* Update internal/ethapi/api.go

Co-authored-by: Martin Holst Swende <martin@swende.se>
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Sep 30, 2022
* Fixes ethereum#24368

Signed-off-by: 0x6f736f646f <blackd0t@protonmail.com>

* Update internal/ethapi/api.go

Co-authored-by: Martin Holst Swende <martin@swende.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fields["logs"] incorrectly set
6 participants