Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rlp: add WriteString method #24425

Merged
merged 1 commit into from Feb 24, 2022
Merged

rlp: add WriteString method #24425

merged 1 commit into from Feb 24, 2022

Conversation

ucwong
Copy link
Contributor

@ucwong ucwong commented Feb 18, 2022

 w.WriteString undefined (type rlp.EncoderBuffer has no field or method WriteString)

@fjl
Copy link
Contributor

fjl commented Feb 22, 2022

Is that an error from output of rlpgen?

@fjl fjl changed the title rlp/encbuffer : add writeString method rlp: add WriteString method Feb 22, 2022
@fjl fjl merged commit 687e4dc into ethereum:master Feb 24, 2022
1 check passed
@fjl fjl added this to the 1.10.17 milestone Feb 24, 2022
@ucwong
Copy link
Contributor Author

ucwong commented Feb 25, 2022

Is that an error from output of rlpgen?

No, just easy to use

@fjl
Copy link
Contributor

fjl commented Feb 25, 2022

I checked it, and rlpgen does actually generate calls to WriteString :)

sidhujag pushed a commit to syscoin/go-ethereum that referenced this issue Feb 25, 2022
rlpgen outputs calls to this method for values of type string.
gurukamath pushed a commit to gurukamath/go-ethereum that referenced this issue Feb 27, 2022
rlpgen outputs calls to this method for values of type string.
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
rlpgen outputs calls to this method for values of type string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants