Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth/downloader: fix off-by-one error in test causing 50% fails #24545

Merged
merged 1 commit into from Mar 16, 2022

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Mar 16, 2022

I miscalculated which header is the one being retrieved that needs to be delayed to trigger the data race. It caused no delay thus 50% success 50% fail for the test.

@karalabe karalabe added this to the 1.10.17 milestone Mar 16, 2022
@karalabe karalabe merged commit 2352c72 into ethereum:master Mar 16, 2022
1 check was pending
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Mar 16, 2022
eth/downloader: fix off-by-one error in test causing 50% fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant