Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sstore gas comment typo #24583

merged 1 commit into from Mar 29, 2022


Copy link

@lispc lispc commented Mar 25, 2022

No description provided.

Copy link

@MariusVanDerWijden MariusVanDerWijden left a comment


@lispc lispc changed the title fix sstore gas comment type fix sstore gas comment typo Mar 25, 2022
ligi approved these changes Mar 29, 2022
@karalabe karalabe added this to the 1.10.17 milestone Mar 29, 2022
@karalabe karalabe merged commit b06e8c4 into ethereum:master Mar 29, 2022
@lispc lispc deleted the fix/sstore_gas_comment_typo branch Mar 29, 2022
sidhujag pushed a commit to syscoin/go-ethereum that referenced this issue Apr 3, 2022
JacekGlen pushed a commit to JacekGlen/go-ethereum that referenced this issue May 26, 2022
bgelb added a commit to bgelb/go-ethereum that referenced this issue Jun 16, 2022
* core/types: improve error for too short transaction / receipt encoding (ethereum#24256)

Co-authored-by: Felix Lange <>

* rlp, trie: faster trie node encoding (ethereum#24126)

This change speeds up trie hashing and all other activities that require
RLP encoding of trie nodes by approximately 20%. The speedup is achieved by
avoiding reflection overhead during node encoding.

The interface type trie.node now contains a method 'encode' that works with
rlp.EncoderBuffer. Management of EncoderBuffers is left to calling code.
trie.hasher, which is pooled to avoid allocations, now maintains an
EncoderBuffer. This means memory resources related to trie node encoding
are tied to the hasher pool.

Co-authored-by: Felix Lange <>

* cmd/geth: make authrpc listening address settable from command line (ethereum#24522)

The default listening address "localhost" is not sufficient when running
geth in Docker.

* core, ethdb, tests, trie: introduce database snapshot (ethereum#24486)

* core/rawdb, cmd, ethdb, eth: implement freezer tail deletion (ethereum#23954)

* core/rawdb, cmd, ethdb, eth: implement freezer tail deletion

* core/rawdb: address comments from martin and sina

* core/rawdb: fixes cornercase in tail deletion

* core/rawdb: separate metadata into a standalone file

* core/rawdb: remove unused code

* core/rawdb: add random test

* core/rawdb: polish code

* core/rawdb: fsync meta file before manipulating the index

* core/rawdb: fix typo

* core/rawdb: address comments

* eth/protocols/snap: avoid estimating infinite percentage

* graphql: fee history fields (ethereum#24452)

This PR adds the `NextBaseFeePerGas` to `Block` and `EffectiveTip` to `Transaction` to make it easier for clients to compute fee history themselves via graphql queries.

* eth/protocols/snap: a little typo Merkel -> Merkle (ethereum#24530)

* eth/downloader: implement beacon sync (ethereum#23982)

* eth/downloader: implement beacon sync

* eth/downloader: fix a crash if the beacon chain is reduced in length

* eth/downloader: fix beacon sync start/stop thrashing data race

* eth/downloader: use a non-nil pivot even in degenerate sync requests

* eth/downloader: don't touch internal state on beacon Head retrieval

* eth/downloader: fix spelling mistakes

* eth/downloader: fix some typos

* eth: integrate legacy/beacon sync switchover and UX

* eth: handle UX wise being stuck on post-merge TTD

* core, eth: integrate the beacon client with the beacon sync

* eth/catalyst: make some warning messages nicer

* eth/downloader: remove Ethereum 1&2 notions in favor of merge

* core/beacon, eth: clean up engine API returns a bit

* eth/downloader: add skeleton extension tests

* eth/catalyst: keep non-kiln spec, handle mining on ttd

* eth/downloader: add beacon header retrieval tests

* eth: fixed spelling, commented failing tests out

* eth/downloader: review fixes

* eth/downloader: drop peers failing to deliver beacon headers

* core/rawdb: track beacon sync data in db inspect

* eth: fix review concerns

* internal/web3ext: nit

Co-authored-by: Marius van der Wijden <>

* rpc: fix defer in test (ethereum#24490)

Co-authored-by: Felix Lange <>

* go.mod: upgrade upnp dependency (ethereum#24536)

* core/rawdb: add specified key length iterator (ethereum#24535)

* trie: fix two issues in trie iterator (ethereum#24539)

* trie: fix memory leak in trie iterator

In the trie iterator, live nodes are tracked in a stack while iterating.
Popped node states should be explictly set to nil in order to get

* trie: fix empty trie iterator

* build: fix linter install on windows (ethereum#24523)

* eth/tracers: use hex encoding for debug_traceBlock argument (ethereum#24517)

* cmd/geth: set EnableBashCompletion = true (ethereum#24313)

prepare ethereum#24145

* cmd/geth: rename --whitelist to --eth.requiredblocks (ethereum#24505)

* cmd, eth: Rename whitelist argument to peer.requiredblocks

* eth/ethconfig: document PeerRequiredBlocks better

* cmd/utils: rename new flag to --eth.requiredblocks

Co-authored-by: Felix Lange <>

* build, Dockerfile: bump Go to 1.18

* eth/downloader: fix off-by-one error in test causing 50% fails

* les, tests: fix vflux fuzzer by removing unnecessary panic (ethereum#24537)

* crypto: use btcec/v2 for no-cgo (ethereum#24533)

This updates the no-cgo implementations in the crypto package to use
the module instead of the older btcec
package that was part of the main module.

name                   old time/op  new time/op  delta
EcrecoverSignature-32   198µs ± 0%   144µs ± 0%  -27.11%
VerifySignature-32      177µs ± 0%   128µs ± 0%  -27.44%
DecompressPubkey-32    20.9µs ± 0%  10.1µs ± 0%  -51.51%

Use (*ModNScalar).IsOverHalfOrder instead of math/big.Int when checking
for malleable signatures.

* core: eth: implement Kiln-v2 spec (ethereum#24506)

* core/beacon: eth/catalyst: updated engine api to new version

* core: implement exchangeTransitionConfig

* core/beacon: prevRandao instead of Random

* eth/catalyst: Fix ExchangeTransitionConfig, add test

* eth/catalyst: stop external miners on TTD reached

* node: implement --authrpc.vhosts flag

* core: allow for config override on non-mainnet networks

* eth/catalyst: fix peters comments

* eth/catalyst: make stop remote sealer more explicit

* eth/catalyst: add log output

* cmd/utils: rename to authrpc.addr

* eth/catalyst: disable the disabling of the miner

* eth: core: remove notion of terminal pow block

* eth: les: more of peters nitpicks

* core, params: add kiln flag (ethereum#24548)

* docs/postmortems: fix spelling (ethereum#24558)

* eth/downloader: terminate beacon sync early when linked to local chain (ethereum#24550)

* eth/downloader: terminate beacon sync early when linked to local chain

* eth/downloader: fix backfiller resume on early beacon termination

* core/rawdb: fix db commands (ethereum#24540)

* crypto/bls12381: go format

* core: store genesis allocation and recommit them if necessary (ethereum#24460)

* core: store genesis allocation and recommit them if necessary

* core: recover predefined genesis allocation if possible

* eth/downloader: ignore zero size header batch for importing (ethereum#24569)

* eth/downloader: ignore zero size header batch for importing

* core, light: reject empty header batch for importing

* core/rawdb: simple legacy receipt converter (ethereum#24028)

* cmd,core: add simple legacy receipt converter

core/rawdb: use forEach in migrate

core/rawdb: batch reads in forEach

core/rawdb: make forEach anonymous fn

cmd/geth: check for legacy receipts on node startup

fix err msg

Co-authored-by: rjl493456442 <>

fix log

Co-authored-by: rjl493456442 <>

fix some review comments

add warning to cmd

drop isLegacy fn from migrateTable params

add test for windows rename

test replacing in windows case

* minor fix

* sanity check for tail-deletion

* add log before moving files around

* speed-up hack for mainnet

* fix mainnet check, use networkid instead

* check mainnet genesis

* review fixes

* resume previous migration attempt

* core/rawdb: lint fix

Co-authored-by: Martin Holst Swende <>

* eth/downloader: fix flakey test (ethereum#24576)

* eth/catalyst: fix log message (ethereum#24574)

* node: allow JWT pass by file only (ethereum#24579)

* build: upgrade to golangci-lint v1.45.2 (ethereum#24586)

* internal/build: show ppa upload process stdout on stdout (ethereum#24588)

* internal/build: prevent travis timeout during ppa upload (ethereum#24589)

* internal/build: exit sftp upload (ethereum#24590)

* build: close sftp connection when done (ethereum#24593)

* core: set ttd override on all chain variations

* core/vm: fix sstore gas comment type (ethereum#24583)

* cmd/geth: change to non-fatal error message when legacy receipt storage is not implemented (ethereum#24603)

* cmd/geth: only check for presence of legacy receipts if developer mode is not enabled

* cmd/geth: degrade log level

* cmd/geth: fix format

Co-authored-by: Gary Rong <>

* eth/catalyst: only apply block if we actually have the state (ethereum#24598)

* eth/catalyst: only apply block if we actually have the state

* add header to payload queue

* Update cmd/geth/dbcmd.go

Co-authored-by: Martin Holst Swende <>

Co-authored-by: Martin Holst Swende <>

* params: go-ethereum v1.10.17 stable

* params: begin v1.10.18 release cycle

* rlp: fix typo in comment (ethereum#24595)

Co-authored-by: Yong Yang <>

* core/state/snapshot: clean up the generation code (ethereum#24479)

* go.mod : upnp 1.0.3 stable version (ethereum#24573)

* internal/ethapi: add refund to StructLogRes (ethereum#24567)

* internal/ethapi: add refund to StructLogRes

* Update internal/ethapi/api.go

Co-authored-by: rjl493456442 <>

Co-authored-by: rjl493456442 <>

* eth/tracers/logger: use omitempty to reduce log bloat  (ethereum#24547)

Makes the evm json output less verbose: omitting output of `memory` and `returndata` in case they are empty.

* common/compiler: add extra include paths to solidity compiler (ethereum#24541)

This PR adds a ExtraAllowedPath field to Solidity and exposes two APIs: CompileSource and CompileFiles, which were hidden inside CompileSolidityString and CompileSolidity before.

* core: verify genesis extradata for clique (ethereum#24470)

* Add extra-data checks for clique genesis

* Update genesis.go

* Update genesis.go

* core: simplify clique genesis check

Co-authored-by: Felix Lange <>
Co-authored-by: Martin Holst Swende <>

* eth: change snapshot extension registration failure to warning instead of error (ethereum#24475)

* core: Change Snapshot extension registration failed to Debug

* Update eth/handler.go

Co-authored-by: Martin Holst Swende <>

* trie, les, tests, core: implement trie tracer (ethereum#24403)

Trie tracer is an auxiliary tool to capture all deleted nodes
which can't be captured by trie.Committer. The deleted nodes
can be removed from the disk later.

* core,eth: implement tx-level hooks for tracers (ethereum#24510)

* core,eth: add empty tx logger hooks

* core,eth: add initial and remaining gas to tx hooks

* store tx gasLimit in js tracer

* use gasLimit to compute intrinsic cost for js tracer

* re-use rules in transitiondb

* rm logs

* rm logs

* Mv some fields from Start to TxStart

* simplify sender lookup in prestate tracer

* mv env to TxStart

* Revert "mv env to TxStart"

This reverts commit 6569396.

* Revert "simplify sender lookup in prestate tracer"

This reverts commit ab65bce.

* Revert "Mv some fields from Start to TxStart"

This reverts commit aa50d3d.

* fix intrinsic gas for prestate tracer

* add comments

* refactor

* fix test case

* simplify consumedGas calc in prestate tracer

* eth: clarify the error string on getlogs failure (ethereum#24617)

This PR makes the errors we spit out a bit more clear about what block is problematic.

* eth/downloader: retrieve pivot header from local chain if necessary (ethereum#24610)

* eth/downloader: retrieve pivot header from local chain if necessary

* eth/downloader: improve readability

* eth/downloader: update fix

* eth/downloader: add beacon sync tests

* eth/downloader: remove duplicated code

* README: update free space required (ethereum#24636)

* rpc: fixed a typo (ethereum#24642)

* eth/fetcher: if peers never respond, drop them

* eth/tracers: refactor traceTx to separate out struct logging (ethereum#24326)

* eth/tracers: refactor traceTx to separate out struct logging

review fix

Update eth/tracers/api.go

Co-authored-by: Martin Holst Swende <>

Mv ExecutionResult type to logger package

review fix

impl GetResult for StructLogger

make formatLogs private

confused exit and end..

account for intrinsicGas in structlogger, fix TraceCall test

Add Stop method to logger

Simplify traceTx

Fix test

rm logger from blockchain test

account for refund in structLogger

* use tx hooks in struct logger

* minor

* avoid executionResult in struct logger

* revert blockchain test changes

* README: remove mentions of fast sync (ethereum#24656)

Co-authored-by: Marius van der Wijden <>

* core/state/snapshot: remove noop map item assignment

* cmd/geth: inspect snapshot dangling storage (ethereum#24643)

* cmd/geth: inspect snapshot dangling storage

* cmd/geth: make verify-state invoke verify-dangling

* accounts/abi: handle tuple arrays in ParseSelector (ethereum#24587)

Closes ethereum#24571

* all: use T.TempDir to create temporary test directories (ethereum#24633)

This commit replaces ioutil.TempDir with t.TempDir in tests. The
directory created by t.TempDir is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using ioutil.TempDir
had to be removed manually by calling os.RemoveAll, which is omitted in
some tests. The error handling boilerplate e.g.

	defer func() {
		if err := os.RemoveAll(dir); err != nil {

is also tedious, but t.TempDir handles this for us nicely.

Signed-off-by: Eng Zer Jun <>

* les: fix panic in ultralight client sync (ethereum#24641)

* log: modify lock defer unlock order in sync handler (ethereum#24667)

This modifies the order of Lock() defer Unlock() to follow the more
typically used pattern.

* build/deb: update Debian control file to remove unencrypted git protocol (ethereum#24676)

* core/types: make "miner" optional in Header JSON (ethereum#24666)

"miner" is not set for pending block responses in some cases.

Fixes ethereum#24632

* cmd: set DefaultGasLimit to 30M (ethereum#24680)

* cmd: set DefaultGasLimit to 30M, rem deprec. Flag

* cmd: revert flag deprecation

* core: fix benchmark panic (ethereum#24657)

This PR fixes a few panics in the chain marker benchmarks. The root
cause for panic is in chain marker the genesis header/block is not
accessible, while it's expected to be obtained in tests. So this PR
avoids touching genesis header at all to avoid panic.

* abi/base: return error for pending call error (ethereum#24649)

If a pending contract call errors, return that error right away rather
than ignoring it to allow an error somewhere else. This is helpful for
callers to know if perhaps a call failed because of the context deadline
being expired. This change mirrors the behavior of non-pending contract

* build: add imports for go generate tools (ethereum#24682)

This adds a tools.go file to import all command packages used for
go:generate. Doing so makes it possible to execute go-based code
generators using 'go run', locking in the tool version using go.mod.

Co-authored-by: Felix Lange <>

* eth/tracers: make txhash blockhash accessible to native tracers (ethereum#24679)

* cmd/geth: support bigints for --override.terminaltotaldifficulty (ethereum#24646)

Co-authored-by: Felix Lange <>

* eth/downloader: remove stale beacon headers as backfilling progresses (ethereum#24670)

* eth/downloader: remove stale beacon headers as backfilling progresses

* eth/downloader: remove leftover from a previous design

* eth/downloader: do partial beacon cleanups if chain is large

* eth/downloader: linter != heart

* build: upgrade -dlgo version to Go 1.18.1 (ethereum#24689)

* build: upgrade -dlgo version to Go 1.18.1

* build: upgrade -dlgo version for macOS to Go 1.18.1

* eth/downloader: resolve local header by hash for beacon sync (ethereum#24691)

* eth/downlaoder: resolve local header by hash for beacon sync

* eth/downloader: fix error message

* eth/downloader: cap the reverse header resolving

* eth/downloader: re-enable tests

* eth/downloader: add warning logs

* go.mod: upgrade btcec and add 'chainhash' module requirement (ethereum#24700)

See ethereum#24554 and btcsuite/btcd#1839

This is an attempt to resolve a Go module dependency issue that arises
when both '' and the older, non-v2
btcd module are required as dependencies.

* trie: remove unused makeHashNode (ethereum#24702)

* core/vm: fix typo (ethereum#24714)

Was just browsing the code and found this.

* eth/downloader: fix typo in downloader.go (ethereum#24704)

synchornization -> synchronization

* eth/tracers/logger: remove unnecessary comparisons in accessList.equal (ethereum#24663)

This change removes extraneous/unnecessary checks for equality
when comparing 2 accessList values A and B. Given that we validate that
their lengths of A and B are equal, if so and if every element in A is
in B, reflexively every element in B is already in A. If that weren't
the case and an element g existed in A but not in B, that would mean
that there is an extra element and hence a mathematical contradiction.

Fixes ethereum#24658

* update Go min required version to 1.16 (ethereum#24713)

* .github: update CODEOWNERS (ethereum#24743)

* internal/flags: fix godoc (ethereum#24734)

* cmd/faucet: fix genesis flag and improve documentation (ethereum#24735)

* cmd/evm: ensure input length is even (ethereum#24721)

* cmd/evm: ensure input length is even

* cmd/evm: minor nit + lintfix

Co-authored-by: Martin Holst Swende <>

* fix typo (ethereum#24731)

* mobile: fix receipt encoding to json (ethereum#24701)

* p2p: fix type of DiscSubprotocolError (ethereum#24747)

It was 'int' accidentally, should be DiscReason instead.

* all: use 'embed' instead of go-bindata (ethereum#24744)

* cmd/geth, core/state/snapshot: fix flaw in dangling-storage check + inspect difflayers (ethereum#24677)

This PR fixes the flaw that @rjl493456442 found in , namely, that the snapshot iterator uses the combined (disk + difflayers) 'view', wheres the raw iterator uses only the disk 'view'.

This PR instead splits up the work: one phase is iterating the disk layer data, another phase is loading the journalled difflayers and performing the same check there.

* cmd/*: refactor get flag value (ethereum#24761)

* consensus/ethash: fix typos in var names (ethereum#24745)

* internal/ethapi: add db operations to api (ethereum#24739)

Adds `debug_dbGet` method to rpc api

* core/types: fix unhandled errors in TestTransactionCoding (ethereum#24692)

* cmd/utils: utilize beacon wrapper in makechain (ethereum#24620)

* cmd/utils: utilize beacon wrapper in makechain

* cmd/utils: fix fake-pow to also be wrapped in beacon

* consensus/misc: correct error message

* all: use common.FileExist for checking file existence (ethereum#24748)

* ethclient/gethclient: return storage proofs in GetProof (ethereum#24697)

Storage proofs were being unmarshalled from the RPC form to the go struct, but were not being included in the final returned struct.

* eth/filters: remove unused struct fields (ethereum#24782)

* cmd/clef: fixups to the python clef poc (ethereum#24440)

This PR fixes up the example python clef wrapper. The poc is intended to demonstrate how to wite a UI for clef, and had severely bitrotted.
With these changes, it "works" in the sense that all the built-in tests triggers the intended python callbacks (no errors about method not found). It does not "work" in the sense that the wrapper can be used as an actual UI. It will auto-reject any signing requests, for example.

* cmd/evm: make evm t8n handle post-merge transitions (ethereum#24546)

This adds the ability to run --state.fork=Merged, and have post-merge rules apply. When doing so, it also requires the input env to contain currentRandom, and enforces the currentDifficulty to be omitted or zero.

* cmd: group network and db path flags together (ethereum#24698)

This PR groups all built-in network flags together and list them in the command as a whole.

And all database path flags(datadir, ancient) are also grouped, since usually these two are
used together.

* accounts: fix typo in comments (ethereum#24805)

* docker: speed up docker image build (ethereum#24796)

This PR improves the docker build speed for repeated builds where go.mod and go.sum do no change, by placing the downloaded dependencies in a lower layer

* cmd/utils: double limit on free-disk monitor (ethereum#24781)

This PR doubles the limit on which to trigger automatic shutdown, and also changes the timer to run once every 30s instead of 60s.

* build: fix formatted logs (ethereum#24807)

Changed `log.Fatal` to `log.Fatalf()` as it has a parameter...

* build: ppa build for jammy (ubuntu 22.04)

* graphql: add rawReceipt field to transaction type (ethereum#24738)

* graphql: add tx receiptsRLP field

* use MarshalBinary

Co-authored-by: Ryan Schneider <>

* update schema

Co-authored-by: Ryan Schneider <>

* rename to rawReceipt

* indent fix

Co-authored-by: Ryan Schneider <>

* eth/filters: fix code comment (ethereum#24799)

* cmd/geth: fix init genesis for dev (ethereum#24693)

* cmd/geth: fix init genesis for dev

* use ancient flag for init genesis cmd

* cmd, eth: fix required blocks regression

* core: fix WriteBlockAndSetHead documentation (ethereum#24818)

* core: recover state when beacon sets canonical head if it's missing (ethereum#24613)

* core: recover the state in SetChainHead if the head state is missing

* core: disable test logging

* core: address comment from martin

* core: improve log level in case state is recovered

* core, eth, les, light: rename SetChainHead to SetCanonical

* eth/protocols/eth: fix godoc comments (ethereum#24810)

Co-authored-by: Martin Holst Swende <>

* eth/filters: remove explicit continue label in filterLogs (ethereum#24795)

The loop label can be removed because this 'continue' statement
is not in a nested loop.

* p2p/simulations: escape mockerType value from request (ethereum#24822)

Co-authored-by: Felix Lange <>

* p2p/simulations: fix typo in network_test.go (ethereum#24824)

* miner: discard interrupted blocks (ethereum#24638)

During mining, when a new head arrives and interrupts the block building, the block being built should not be commited (but discarded). Committing the interrupted block introduces unnecessary delay, and possibly causes miner to mine on the previous head, which could result in higher uncle rate.

* core/rawdb: untie freezer and ancient chain data (ethereum#24684)

Previously freezer has only been used for storing ancient chain data, while obviously it can be used more. This PR unties the chain data and freezer, keep the minimal freezer structure and move all other logic (like incrementally freezing block data) into a separate structure called ChainFreezer.

This PR also extends the database interface by adding a new ancient store function AncientDatadir which can return the root directory of ancient store. The ancient root directory can be used when we want to open some other ancient-stores (e.g. reverse diff freezer).

* core/vm: implement EIP-3855: PUSH0 instruction (ethereum#24039)

* core/vm: Implement PUSH0

* Move PUSH0 to enable3855

* Add method doc

* eth/fetcher: avoid hang in tests (partial fix for ethereum#23331) (ethereum#23351)

* eth/fetcher: fix test to avoid hanging. Partial fix for ethereum#23331

* eth/filters: avoid dangling goroutines

* eth/fetcher: revert closing of proceed

* signer/fourbyte: import new signatures (ethereum#22865)

* abi: fix checks when all fields are indexed (ethereum#24792)

This PR fixes abi checks in the edge case where all arguments are indexed

* core/state/snapshot: fix race condition (ethereum#24685)

Fixes three race conditions found through fuzzing by David Theodore

* all: replace strings.Replace with string.ReplaceAll (ethereum#24835)

* internal: drop TestSignCliqueBlock (ethereum#24837)

* signer/fourbyte: remove offending signatures (ethereum#24842)

* core/vm: update benchmark to use Errorf instead of Sprintf (ethereum#24845)

* eth/protocols/snap: sort trienode heal requests by path (ethereum#24779)

* sort snap trienode heal requests

* eth/protocols/snap: remove debug code

* eth/protocols/snap: simplify sort, generate pathsets later

* eth/protocols/snap: review concern

* eth/protocols/snap: renamings

* eth/protocols/snap: add comments in Merge

* eth/protocols/snap: remove variable 'last' in Merge

* eth/protocols/snap: fix lint flaws in test

Co-authored-by: Felix Lange <>

* cmd/geth: print info banner for --dev mode (ethereum#24759)

Co-authored-by: nedifi <>
Co-authored-by: Felix Lange <>

* core/vm: clean up some dead functions (ethereum#24851)

* core/vm: separate opcode group for 0x20 range (ethereum#24850)

* ethclient: add PeerCount method (ethereum#24849)

* adding peer count function

* Update ethclient.go

Co-authored-by: Felix Lange <>

* core/vm: optimize Memory.Set32 (ethereum#24847)

* core/vm: remove unnecessary memset for Memory.Set32

* core/vm: optimize Memory.Set32

* graphql: fix long literal passed in a variable (ethereum#24864)

* core/vm: for tracing, do not report post-op memory

* internal/ethapi: add debug_getRawReceipts RPC method (ethereum#24773)

Adds a method to retrieve all the binary encoded receipts from a block

* params: set ropsten TTD for TheMerge (ethereum#24876)

* cmd/utils: add deprecation warning for Rinkeby

* core/asm: use strings.Builder and fix godoc issues (ethereum#24861)

* all: replace uses of ioutil with io and os (ethereum#24869)

* cmd/geth: update vulnerabilities.json testdata (ethereum#24856)

* core/vm: reduce overhead in instructions-benchmark (ethereum#24860)

* core/vm: reduce footprint of OP benchmark

* core/vm: for opBenchmark, add code to detect inputs mutation

* Update core/vm/instructions_test.go

Co-authored-by: Martin Holst Swende <>

* core/vm: opBenchmark, stop timer before sanity-test code

Co-authored-by: Martin Holst Swende <>

* eth: fix flaky test, don't attach empty slots/proofs (ethereum#24885)

* eth/protocols/snap: don't include empty snapshot slot slice

This PR fixes the snapshot storage serving handler. In snap protocol
the response is capped by the response size. Server can cutdown the
response if the accumulated byte size exceeds the local hard limit.

It means we can meet a special scenario that there is no storage slot
included for a requested account, but we attach the proof for this
account by mistake.

So in the prover side, when it meets a empty storage response but with
a valid proof proves there are some more slots left in the trie, then
requestor will reject this response and disconnect with server.

In this PR, if there is no storage slot served for the requested account,
then no proof should be attached as well.

* eth/protocols/snap: loosen restrictions for flaky tests

* eth/catalyst: fix flaky test in catalyst

* graphql: add raw fields to block and tx (ethereum#24816)

* eth/catalyst: set the correct LatestValidHash (ethereum#24855)

* eth/catalyst: set the correct LatestValidHash

* eth/catalyst: core: return LVH during reorg, rework invalid teminal block

* eth/catalyst: nitpicks

* cmd/geth: add `db check-state-content` to verify integrity of trie nodes (ethereum#24840)

This PR adds db tooling (geth db check-state-content)  to verify the integrity of trie nodes. It iterates through the 32-byte key space in the database, which is expected to contain RLP-encoded trie nodes, addressed by hash.

* all: use strings.EqualFold for string comparison (ethereum#24890)

* all: replace non-trivial uses of package ioutil with os (ethereum#24886)

Co-authored-by: Martin Holst Swende <>

* ethdb/remotedb, cmd: add support for remote (readonly) databases (ethereum#24836)

* ethdb/remotedb, cmd: add support for remote (readonly) databases

* ethdb/remotedb: minor changes

* ethdb/remotedb: close the conn

* cmd, ethdb: add rpc accessor for ancient data

* internal/ethapi: license

* ethdb/remotedb: linter fixes

* core, eth, internal, rpc: implement final block (ethereum#24282)

* eth: core: implement finalized block

* eth/catalyst: fix final block

* eth/catalyst: update finalized head gauge

* internal/jsre/deps: updated web3.js to allow for finalized block

* eth/catalyst: make sure only one thread can call fcu

* eth/catalyst: nitpicks

* eth/catalyst: use plain mutex

* eth: nitpicks

* eth/catalyst, miner: build the execution payload async (ethereum#24866)

* eth/catalyst: build the execution payload async

* miner: added comment, added test case

* eth/catalyst: miner: move async block production to miner

* eth/catalyst, miner: support generate seal block async

* miner: rework GetSealingBlockAsync to use a passed channel

* miner: apply rjl's diff

* eth/catalyst: nitpicks

Co-authored-by: Gary Rong <>

* eth/tracers/js: goja tracer (ethereum#23773)

This adds a JS tracer runtime environment based on the Goja VM. The new
runtime replaces the duktape runtime, which will be removed soon.

Goja is implemented in Go and is faster for cases where the Go <-> JS
transition overhead dominates overall performance. It is faster because
duktape is written in C, and the transition cost includes the cost of using
cgo. Another reason for using Goja is that go-duktape is not maintained

We expect the performace of JS tracing to be at least as good or better with
this change.

* params: update goerli bootnodes (ethereum#24900)

* params: update goerli bootnodes

* params: use ip for enodes

* params: fix broken linter

* ethdb/remotedb: fix flawed check in Has/HasAncient

* core: fix the order of address in queue (ethereum#24907)

reverse the order of address in queue

* tests: update reference tests (ethereum#24899)

* tests: update reference tests

* tests: fix flaw in state test execution

* f

* eth/tracers/js: add memory.length method (ethereum#24887)

* eth/catalyst: update implementation to spec (ethereum#24802)

* eth/catalyst: return invalid payload attributes error

* eth/catalyst: implement LVH as specified, add tests

* eth/catalyst: return current block hash not header hash

* eth/catalyst: fix test

* eth/catalyst: bring error codes in line with spec

* core, eth, les, rpc: polish catalyst errors, add context

* build/bot: add mac build script (ethereum#24917)

* build/bot: remove xctool invocation in macos build script (ethereum#24918)

* build/bot: add (ethereum#24919)

* build/bot: avoid install of python-bzrlib, python-paramiko in PPA build (ethereum#24921)

* build/bot: create .ssh directory in (ethereum#24922)

* core/state/snapshot: detect and clean up dangling storage snapshot in generation (ethereum#24811)

* core/state/snapshot: check dangling storages when generating snapshot

* core/state/snapshot: polish

* core/state/snapshot: wipe the last part of the dangling storages

* core/state/snapshot: fix and add tests

* core/state/snapshot: fix comment

* README: remove mentions of fast sync (ethereum#24656)

Co-authored-by: Marius van der Wijden <>

* core, cmd: expose dangling storage detector for wider usage

* core/state/snapshot: rename variable

* core, ethdb: use global iterators for snapshot generation

* core/state/snapshot: polish

* cmd, core/state/snapshot: polish

* core/state/snapshot: polish

* Update core/state/snapshot/generate.go

Co-authored-by: Martin Holst Swende <>

* ethdb: extend db test suite and fix memorydb iterator

* ethdb/dbtest: rollback changes

* ethdb/memorydb: simplify iteration

* core/state/snapshot: update dangling counter

* core/state/snapshot: release iterators

* core/state/snapshot: update metrics

* core/state/snapshot: update time metrics

* metrics/influxdb: temp solution to present counter meaningfully, remove it

* add debug log, revert later

* core/state/snapshot: fix iterator panic

* all: customized snapshot iterator for backward iteration

* core, ethdb: polish

* core/state/snapshot: remove debug log

* core/state/snapshot: address comments from peter

* core/state/snapshot: reopen the iterator at the next position

* ethdb, core/state/snapshot: address comment from peter

* core/state/snapshot: reopen exhausted iterators

Co-authored-by: Tbnoapi <>
Co-authored-by: Marius van der Wijden <>
Co-authored-by: Martin Holst Swende <>

* accounts/abi: validate fieldnames, fixes ethereum#24930 (ethereum#24932)

* common/compiler, cmd/abigen: remove solc/vyper compiler integration

* eth/tracers/js: drop duktape engine (ethereum#24934)

ethereum#23773 added a JS tracer which uses Goja as its engine. In this PR I remove the previous tracer which used duktape as well as remove the dependencies.

This PR also comes with 2 fixes in the Goja tracer and one small behavioural change:

    I had handled errors in the native Go functions by panicing. My oversight was that Goja only handles panics with a Goja.Value as argument. The difference is panic(goja.Value) allows JS to catch the exception whereas Interrupt(error) doesn't.
    There was a race in how I handled Stop.
    Because of 1. some of the methods that simply return nil on error (like memory.slice) now throw an exception.

* signer/core: always pad clique header extra data with space for sealer's signature (ethereum#24941)

* signer/core: always pad clique header extra data with space for sealer's signature

* capitalize comment

* go.mod: upgrade to btcsuite/btcd/btcec v2.2.0 (ethereum#24939)

This should fully resolve dependency conflict issues in modules
that also depend on btcsuite/btcd v0.22.0.

* params: update CHTs for Geth 1.10.18

* all: update license headers and AUTHORS from git history (ethereum#24947)

* AUTHORS: remove one more duplicate entry (ethereum#24950)

* go.mod: upgrade to docker v1.6.2 (ethereum#24956)

This upgrade is necessary to silence a Dependabot warning.

* params: go-ethereum v1.10.18 stable

* params: begin v1.10.19 release cycle

* cmd/geth: exit when freezer has legacy receipts (ethereum#24943)

In ethereum#24028 we flagged a warning when finding legacy receipts in the freezer. This PR nudges users a bit more strongly by preventing geth from starting in this case until receipts have been migrated.

It also adds a flag --ignore-legacy-receipts which when present allows geth to start normally.

* cmd/abigen: accept combined-json via stdin (ethereum#24960)

* params: set emergency ropsten TTD to 100_000_000_000_000_000_000_000 (ethereum#24975)

* core: use less memory during reorgs (ethereum#24616)

This PR significantly reduces the memory consumption of a long reorg

* cmd/geth: extend traverseRawState command (ethereum#24954)

This PR adds node verification into traverseRawState command, so corrupted trie nodes can also be detected.

* consensus/clique: fix race condition (ethereum#24957)

* consensus/clique: remove race condition

* consensus/clique: fix one more signer data race

Co-authored-by: Gary Rong <>

* eth/catalyst: fix edge case in NewPayload (ethereum#24955)

Fixes an issue where we would accept a NewPayload where the grandparent is already post ttd, and the parent still has a Difficulty

* contracs/checkpointoracle: fix directives (ethereum#24944)

contracts/checkpointoracle: redefine go-generate logic

* eth/filters: use buffered channel to avoid goroutine leak (ethereum#24928)

* core/beacon: prevent invalid logsBloom length panic (ethereum#24946)

* core/beacon: prevent invalid logsBloom length panic

* core/beacon: prevent negative baseFeePerGas

* Update core/beacon/types.go

Co-authored-by: Martin Holst Swende <>

* eth/catalys: go format

Co-authored-by: Martin Holst Swende <>

* core: fix canonical hash marker update (ethereum#24996)

* core: fix reorg

* core: revert change for memory efficiency

* core: revert changes

* eth/tracers: add support for block overrides in debug_traceCall (ethereum#24871)

This PR adds support for block overrides when doing debug_traceCall.

- Previously, debug_traceCall against pending erroneously used a common.Hash{} stateroot when looking up the state, meaning that a totally empty state was used -- so it always failed,
- With this change, we reject executing debug_traceCall against pending.
- And we add ability to override all evm-visible header fields.

* tests/fuzzers/bls12381: Add BLST to fuzzing support (ethereum#24249)

* tests/fuzzers/bls12381: added blst library

* go.mod: added blst dependency

* tests/fuzzers/bls12381: stuff

* tests/fuzzers/bls12381: added blst to pairing fuzzer

* eth/catalyst: return 0x0 on Invalid block on top of pow block (ethereum#25006)

* node: make jwt test less dependent on time (ethereum#25016)

* consensus/misc: reduce allocations and improve comments in CalcBaseFee (ethereum#24958)

* consensus/misc: reduce allocations in CalcBaseFee

* consensus/misc: add formulas of CalcBaseFee

* go.mod: set go version to 1.17 (ethereum#24926)

set go version to 1.17

* go.mod: clean up (ethereum#25017)

* core/vm: optimize jumpdest analysis (ethereum#23500)

core/vm: optimize PUSH opcode discrimination

* tests/fuzzers/bls12381: fix blst deserializing (ethereum#25036)

* tests/fuzzers/bls12381: fix blst deserializing

* tests/fuzzers/bls12381: fix blst deserializing

* cmd/geth, core/state/snapshot: rework journal loading, implement account-check (ethereum#24765)

* cmd/geth, core/state/snapshot: rework journal loading, implement account-check

* core/state/snapshot, cmd/geth: polish code (ethereum#37)

* core/state/snapshot: minor nits

* core/state/snapshot: simplify error logic

* cmd/geth: go format

Co-authored-by: rjl493456442 <>

* all: introduce trie owner notion (ethereum#24750)

* cmd, core/state, light, trie, eth: add trie owner notion

* all: refactor

* tests: fix goimports

* core/state/snapshot: fix ineffasigns

Co-authored-by: Martin Holst Swende <>

* eth/api: use `hexutil.Bytes` for account range method (ethereum#25024)

eth/api: use hexutil.Bytes for range at methods

* eth/tracers: fix typo in 4byte_tracer_legacy.js (ethereum#25020)

indentifier -> identifier

* trie: move locking into trieDB insert method (ethereum#25030)

Move locking into trieDB insert function

* params: update ropsten terminal total difficulty block (ethereum#25018)

* eth/filters: fix getLogs for pending block (ethereum#24949)

* eth/filters: fix pending for getLogs

* add pending method to test backend

* fix block range validation

* accounts/abi/bind: fix duplicate field names in the generated go struct (ethereum#24924)

* accounts/abi/bind: fix duplicate field names in the generated go struct ethereum#24627

* accounts, cmd/abigen: resolve name conflicts

* ci lint, accounts/abi: remove unused function overloadedArgName

Co-authored-by: Gary Rong <>

* tests/fuzzers/bls12381: fix blst pairing (ethereum#25037)

* tests/fuzzers/bls12381: fix blst pairing

* tests/fuzzers/bls12381: only build on gofuzz

* tests/fuzzers/bls12381: remove unused code

* tests/fuzzers/bls12381: remove unused code

* p2p/discover: fix panicky test (ethereum#25038)

* accounts: increase parseURL test coverage (ethereum#25033)

accounts/url: add test logic what check null string to parseURL()

* eth, les, params: log chain config a bit saner (ethereum#24904)

Previously on Geth startup we just logged the chain config is a semi-json-y format. Whilst that worked while we had a handful of hard-forks defined, currently it's kind of unwieldy. 

This PR converts that original data dump and converts it into a user friendly - alas multiline - log output.

* p2p: use errors.Is for error comparison (ethereum#24882)

Co-authored-by: Felix Lange <>

* rpc: swap out timer metrics to histograms

* eth/catalyst: remove unauthenticated 'engine' api (ethereum#24997)

Removes engine from any unauthenticated RPC service.

* core/types: remove unused field 'td' in Block (ethereum#25010)

* core/types: improve LogForStorage and ReceiptForStorage comments (ethereum#25032)

Co-authored-by: Felix Lange <>

* core/evm: fix error in comment (ethereum#25040)

Co-authored-by: Martin Holst Swende <>

* internal/ethapi: fix typo in comment (ethereum#25056)

typo error: keccack256 -> keccak256

* Chore:  Minimal gramatical errors (signleton -> singleton) (ethereum#25057)

core: fix typos

* all: more linters (ethereum#24783)

This enables the following linters

- typecheck
- unused
- staticcheck
- bidichk
- durationcheck
- exportloopref
- gosec

WIth a few exceptions.

- We use a deprecated protobuf in trezor. I didn't want to mess with that, since I cannot meaningfully test any changes there.
- The deprecated TypeMux is used in a few places still, so the warning for it is silenced for now.
- Using string type in context.WithValue is apparently wrong, one should use a custom type, to prevent collisions between different places in the hierarchy of callers. That should be fixed at some point, but may require some attention.
- The warnings for using weak random generator are squashed, since we use a lot of random without need for cryptographic guarantees.

* cmd/utils: update --ropsten description (ethereum#25078)

* readme,eth: remove references to (ethereum#25086)

* cmd/ethkey: use accounts.TextHash (ethereum#25069)

* common: improve pretty duration regex (ethereum#25073)

* common: improve pretty duration regex

* common: improve pretty duration regex

* all: prefer `new(big.Int)` over `big.NewInt(0)` (ethereum#25087)

minor performance improvement: `big.NewInt(0).Xxx` -> `new(big.Int).Xxx`

* eth: add missing period at end of sentences (ethereum#25058)

eth: add missing periods on end of comments

* eth: introduce eth67 protocol (ethereum#24093)

The new protocol version removes support for GetNodeData.
See for more information.

Co-authored-by: Felix Lange <>
Co-authored-by: Martin Holst Swende <>

* cmd, params: implement Gray Glacier hard-fork (EIP-5133) (ethereum#25088)

* cmd/geth, params: implement Gray Glacier (EIP-5133)

* cmd/evm: add gray glacier tests

* params: nitpicks

* params: fixes

* node: add info message when JWT secret is loaded (ethereum#25095)

Co-authored-by: Felix Lange <>

* params: release Geth v1.10.19

Co-authored-by: Justus <>
Co-authored-by: Felix Lange <>
Co-authored-by: Qian Bin <>
Co-authored-by: rjl493456442 <>
Co-authored-by: Martin Holst Swende <>
Co-authored-by: Sina Mahmoodi <>
Co-authored-by: 沉风 <>
Co-authored-by: Péter Szilágyi <>
Co-authored-by: Marius van der Wijden <>
Co-authored-by: s7v7nislands <>
Co-authored-by: ucwong <>
Co-authored-by: aaronbuchwald <>
Co-authored-by: ligi <>
Co-authored-by: Guifel <>
Co-authored-by: Ryan Schneider <>
Co-authored-by: Jonathan Chappelow <>
Co-authored-by: alvaroahp11 <>
Co-authored-by: Zhang Zhuo <>
Co-authored-by: jwasinger <>
Co-authored-by: flowerofdream <>
Co-authored-by: Yong Yang <>
Co-authored-by: zhiqiangxu <>
Co-authored-by: Guruprasad Kamath <>
Co-authored-by: Nic Jansma <>
Co-authored-by: John Adler <>
Co-authored-by: Tatsuya Shimoda <>
Co-authored-by: Tbnoapi <>
Co-authored-by: Tangui Clairet <>
Co-authored-by: Eng Zer Jun <>
Co-authored-by: Vaibhaw <>
Co-authored-by: JoeGruffins <>
Co-authored-by: Marius Kjærstad <>
Co-authored-by: Darioush Jalali <>
Co-authored-by: Enrique Ortiz <>
Co-authored-by: Ikko Ashimine <>
Co-authored-by: Emmanuel T Odeke <>
Co-authored-by: Koosha K <>
Co-authored-by: Nikita Kozhemyakin <>
Co-authored-by: henopied <>
Co-authored-by: John Difool <>
Co-authored-by: tia-99 <>
Co-authored-by: Joshua Gutow <>
Co-authored-by: hero5512 <>
Co-authored-by: nujabes403 <>
Co-authored-by: EXEC <>
Co-authored-by: Evgeny Kolyakov <>
Co-authored-by: milesvant <>
Co-authored-by: ImanSharaf <>
Co-authored-by: Mateusz Morusiewicz <>
Co-authored-by: Alex Beregszaszi <>
Co-authored-by: Rachel Franks <>
Co-authored-by: ||= nil <>
Co-authored-by: nedifi <>
Co-authored-by: Felipe Strozberg <>
Co-authored-by: Håvard Anda Estensen <>
Co-authored-by: Afr Schoe <>
Co-authored-by: zhaochonghe <>
Co-authored-by: Eduard S <>
Co-authored-by: Harry Kalodner <>
Co-authored-by: Boqin Qin(秦 伯钦) <>
Co-authored-by: Ivan Kuznetsov <>
Co-authored-by: Jonathan Le Brun <>
Co-authored-by: Paweł Bylica <>
Co-authored-by: lightclient <>
Co-authored-by: lwh <>
Co-authored-by: Seungbae.yu <>
Co-authored-by: Rajaram Gaunker <>
Co-authored-by: henridf <>
Co-authored-by: int88 <>
Co-authored-by: Luozhu <>
Co-authored-by: Gustavo Silva <>
Co-authored-by: Ivan Aracki <>
Co-authored-by: lmittmann <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants