Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, params, tests: add DAO hard-fork balance moves #2800

Closed
wants to merge 7 commits into from

Conversation

karalabe
Copy link
Member

@karalabe karalabe commented Jul 11, 2016

Prerequisite PRs, merge these first to get rid of duplicate commits:


This PR implements the last component of the DAO hard-fork, namely defines the list of DAO addresses the balances of which should be moved and executes the actual state transformation when the DAO hard-fork block arrives.

The PR also adds the DAO consensus tests from the upstream https://github.com/ethereum/tests repo, although as far as I know those tests are still under development, and hence are subject to change.

Note, the fork parameters (block number and refund account) are just placeholders, whereas the DAO drain list may or may not change.

@robotally
Copy link

robotally commented Jul 11, 2016

Vote Count Reviewers
👍 0
👎 0

Updated: Sat Jul 16 10:09:43 UTC 2016

// Set any missing fields due to them being unset or system upgrade
if config.HomesteadBlock == nil {
if ctx.GlobalBool(TestNetFlag.Name) {
config.HomesteadBlock = new(big.Int).Set(params.TestNetHomesteadBlock)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass directly, not copy.

@aakilfernandes
Copy link

Correct me if I'm wrong, but it looks like this leaves the hard fork block to the user. Does this mean that if different users set different blocks, they'll end up on different forks?

@karalabe
Copy link
Member Author

The user can only opt-in/opt-out, default blocks are provided for the
mainnet and testnet. The configurable block number is only meaningful for
private networks (i.e. testing).
On Jul 13, 2016 19:01, "Aakil Fernandes" notifications@github.com wrote:

Correct me if I'm wrong, but it looks like this leaves the hard fork block
to the user. Does this mean that if different users set different blocks,
they'll end up on different forks?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2800 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAH6GbdvNZtcGZchNqay0Ur0bE51ebSoks5qVQvpgaJpZM4JJRtW
.

@aakilfernandes
Copy link

aakilfernandes commented Jul 13, 2016

Got it, thanks. Has the default block number been selected yet?

@karalabe
Copy link
Member Author

Superseeded and merged in #2814.

@karalabe karalabe closed this Jul 16, 2016
@obscuren obscuren removed the review label Jul 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants