-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core, params, tests: add DAO hard-fork balance moves #2800
Conversation
Updated: Sat Jul 16 10:09:43 UTC 2016 |
c5db2a7
to
1dfbc5d
Compare
1dfbc5d
to
3067d7a
Compare
// Set any missing fields due to them being unset or system upgrade | ||
if config.HomesteadBlock == nil { | ||
if ctx.GlobalBool(TestNetFlag.Name) { | ||
config.HomesteadBlock = new(big.Int).Set(params.TestNetHomesteadBlock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pass directly, not copy.
Correct me if I'm wrong, but it looks like this leaves the hard fork block to the user. Does this mean that if different users set different blocks, they'll end up on different forks? |
The user can only opt-in/opt-out, default blocks are provided for the
|
Got it, thanks. Has the default block number been selected yet? |
Superseeded and merged in #2814. |
Prerequisite PRs, merge these first to get rid of duplicate commits:
This PR implements the last component of the DAO hard-fork, namely defines the list of DAO addresses the balances of which should be moved and executes the actual state transformation when the DAO hard-fork block arrives.
The PR also adds the DAO consensus tests from the upstream https://github.com/ethereum/tests repo, although as far as I know those tests are still under development, and hence are subject to change.
Note, the fork parameters (block number and refund account) are just placeholders, whereas the DAO drain list may or may not change.