cmd/geth: add flag to set genesis #32844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
cmd-geth-genesis-flag
branch
from
9dcc734 to
b02b46d
Compare
rjl493456442
reviewed
Oct 9, 2025
| if err := json.NewDecoder(f).Decode(genesis); err != nil { | ||
| Fatalf("Invalid genesis file: %v", err) | ||
| } | ||
| cfg.Genesis = genesis |
There was a problem hiding this comment.
Just want to highlight that, in this case, the ChainID will be used as the NetworkID.
I guess it's expected behavior
kmk142789
approved these changes
Oct 14, 2025
barnabasbusa
approved these changes
Oct 20, 2025
|
LGTM |
Removed the period at the end of the usage description for the GenesisFlag.
rjl493456442
previously approved these changes
Oct 21, 2025
rjl493456442
previously approved these changes
Oct 21, 2025
lightclient
force-pushed
the
cmd-geth-genesis-flag
branch
from
f9cc307 to
caf1b2a
Compare
|
Reverting last commit as it causes an issue with automatically upgrading the mainnet config since no network flag is typically passed. |
rjl493456442
previously approved these changes
Oct 21, 2025
|
Renamed flag to |
rjl493456442
approved these changes
Oct 21, 2025
barnabasbusa
added a commit
to ethpandaops/template-devnets
that referenced
this pull request
Oct 24, 2025
following: ethereum/go-ethereum#32844 --------- Signed-off-by: Barnabas Busa <busa.barnabas@gmail.com>
rjl493456442
added a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Oct 28, 2025
This PR is an alternative to ethereum#32556. Instead of trying to be smart and reuse `geth init`, we can introduce a new flag `--genesis` that loads the `genesis.json` from file into the `Genesis` object in the same path that the other network flags currently work in. Question: is something like `--genesis` enough to start deprecating `geth init`? -- ```console $ geth --datadir data --hoodi .. INFO [10-06|22:37:11.202] - BPO2: @1762955544 .. $ geth --datadir data --genesis genesis.json .. INFO [10-06|22:37:27.988] - BPO2: @1862955544 .. ``` Pull the genesis [from the specs](https://raw.githubusercontent.com/eth-clients/hoodi/refs/heads/main/metadata/genesis.json) and modify one of the BPO timestamps to simulate a shadow fork. --------- Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #32556.
Instead of trying to be smart and reuse
geth init, we can introduce a new flag--genesisthat loads thegenesis.jsonfrom file into theGenesisobject in the same path that the other network flags currently work in.Question: is something like
--genesisenough to start deprecatinggeth init?--
Pull the genesis from the specs and modify one of the BPO timestamps to simulate a shadow fork.