core/txpool: Initialize journal writer for tx tracker #32921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he first time rejournal. Previously, the journal writer is nil until the first time rejournal (default 1h), which means during this period, txs submitted to this node are not written into journal file.
KyrinCode
changed the title
Restore original writer after loading transactions from journal.
KyrinCode
changed the title
Refactor journal load method to use nil writer instead of original writer. Add setWriter method to handle journal file opening for writing new transactions.
Removed journal writer initialization and logging.
rjl493456442
previously approved these changes
Oct 21, 2025
rjl493456442
changed the title
KyrinCode
commented
Oct 21, 2025
rjl493456442
approved these changes
Oct 21, 2025
|
Thanks for catching it! I think it should be ready to go. |
rjl493456442
added a commit
to rjl493456442/go-ethereum
that referenced
this pull request
Oct 28, 2025
Previously, the journal writer is nil until the first time rejournal (default 1h), which means during this period, txs submitted to this node are not written into journal file (transactions.rlp). If this node is shutdown before the first time rejournal, then txs in pending or queue will get lost. Here, this PR initializes the journal writer soon after launch to solve this issue. --------- Co-authored-by: Gary Rong <garyrong0905@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the journal writer is nil until the first time rejournal (default 1h), which means during this period, txs submitted to this node are not written into journal file (transactions.rlp). If this node is shutdown before the first time rejournal, then txs in pending or queue will get lost.
Here, this PR initializes the journal writer soon after launch to solve this issue.