Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/secp256k1: sign with deterministic K (rfc6979) #3561

Merged
merged 1 commit into from Jan 22, 2017

Conversation

Projects
None yet
5 participants
@fjl
Copy link
Contributor

fjl commented Jan 13, 2017

Closes #2190

@fjl fjl added this to the 1.5.7 milestone Jan 13, 2017

@fjl fjl requested review from nagydani and obscuren Jan 13, 2017

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jan 13, 2017

@fjl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @obscuren and @Gustav-Simonsson to be potential reviewers.

@fjl fjl added in progress and removed in progress labels Jan 13, 2017

@nagydani
Copy link

nagydani left a comment

This PR correctly implents the change of the signature function to a deterministic RFC6979-compliant ECDSA signature. The test is a bit naive, but it is enough to weed out accidental mistakes and regressions, which is what it is for.

@karalabe karalabe modified the milestones: 1.5.8, 1.5.7 Jan 16, 2017

@fjl fjl merged commit 96778a1 into ethereum:master Jan 22, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

farazdagi added a commit to status-im/go-ethereum that referenced this pull request Feb 23, 2017

whilei added a commit to ethereumproject/go-ethereum that referenced this pull request Apr 14, 2018

problem: nondeterministic K-value in ECDSA algo
solution: move to a deterministic k-value using RFC6979

rel ethereum/go-ethereum#2190
rel ethereum/go-ethereum#3561
rel #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.