Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts/usbwallet: swap karalabe/gousb to karalabe/hid #3681

Merged
merged 1 commit into from Feb 19, 2017

Conversation

Projects
None yet
5 participants
@karalabe
Copy link
Member

commented Feb 16, 2017

Use hidapi instead of libusb directly. This way macOS and Windows can use their proprietary APIs and we don't have permission issues. Linux remains with libusb.

@karalabe karalabe force-pushed the karalabe:usb-hidapi branch Feb 16, 2017

@arkpar

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2017

You could also use hidraw backend instead of libusb on Linux. It requires a not too ancient kernel but adds support for bluetooth devices. See https://github.com/signal11/hidapi/blob/master/linux/README.txt

@karalabe karalabe force-pushed the karalabe:usb-hidapi branch Feb 16, 2017

@karalabe

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2017

Hey @arkpar, thanks for the tips. Currently the PR indeed is based on hidraw, although it requires libudev for building. I'm not sure whether to keep this version or libusb as I did figure out proper compilation and wrapping for the latter but not for the former. Will look into it though.

@fjl

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2017

Please fork hidapi to your account and add it as a dependency in vendor/

@karalabe

This comment has been minimized.

Copy link
Member Author

commented Feb 16, 2017

Fork what? It's a brand new package. Meh, maybe it would make sense to merge into gousb.

@karalabe karalabe force-pushed the karalabe:usb-hidapi branch 2 times, most recently Feb 16, 2017

@karalabe karalabe changed the title accounts/usbwallet, internal/hidapi: higher level USB access accounts/usbwallet: swap karalabe/gousb to karalabe/hid Feb 17, 2017

@karalabe karalabe force-pushed the karalabe:usb-hidapi branch 2 times, most recently Feb 17, 2017

@karalabe karalabe force-pushed the karalabe:usb-hidapi branch to 6ec8135 Feb 17, 2017

@fjl

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2017

I can confirm that this fixes #3677

@karalabe karalabe added this to the 1.6.0 milestone Feb 17, 2017

@karalabe

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2017

OSX seems to work correctly too based on an initial smoke test by @alexvandesande .

@karalabe karalabe added the pr:review label Feb 17, 2017

@karalabe

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2017

OSX also confirmed by someone on the Ledger slack channel.

@Arachnid Arachnid merged commit e51f65a into ethereum:master Feb 19, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.