Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/geth: added 'geth bug' command #3684

Merged
merged 4 commits into from Feb 20, 2017

Conversation

Projects
None yet
3 participants
@obscuren
Copy link
Member

commented Feb 17, 2017

Added bug command to geth, which will open a browser window
with an issue template and some additional system information.

Preview:

$ geth bug

unspecified-1

Please feel free to suggest additional template information.

@obscuren obscuren added the pr:review label Feb 17, 2017

@mention-bot

This comment has been minimized.

Copy link

commented Feb 17, 2017

@obscuren, thanks for your PR! By analyzing the history of the files in this pull request, we identified @karalabe, @fjl and @zelig to be potential reviewers.

cmd/geth: added 'geth bug' command
Added bug command to geth, which will open a browser window
with an issue template and some additional system information.

@obscuren obscuren force-pushed the obscuren:bug-command branch to 3e55dc6 Feb 17, 2017

@obscuren

This comment has been minimized.

Copy link
Member Author

commented Feb 17, 2017

Would be good if someone could tests this on windows.

"runtime"

"github.com/ethereum/go-ethereum/params"

This comment has been minimized.

Copy link
@karalabe

karalabe Feb 20, 2017

Member

gofmt ;) should remove this empty line

@karalabe karalabe added this to the 1.6.0 milestone Feb 20, 2017

printOSDetails(&buff)

// open a new GH issue
browser.Open("https://github.com/ethereum/go-ethereum/issues/new?body=" + url.QueryEscape(buff.String()))

This comment has been minimized.

Copy link
@karalabe

karalabe Feb 20, 2017

Member

Please add a fallback so that if Open fail, a text is printed to the user to report manually. I.e. https://github.com/golang/go/blob/178307c3a72a9da3d731fecf354630761d6b246c/src/cmd/go/internal/bug/bug.go#L63

@obscuren obscuren force-pushed the obscuren:bug-command branch to 764cc54 Feb 20, 2017

@karalabe

This comment has been minimized.

Copy link
Member

commented Feb 20, 2017

Works on Linux.

@karalabe
Copy link
Member

left a comment

Works on Windows too.

@karalabe karalabe merged commit 94334c2 into ethereum:master Feb 20, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.