New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: drop eth_compile #3740

Merged
merged 1 commit into from Mar 16, 2017

Conversation

Projects
None yet
4 participants
@karalabe
Member

karalabe commented Mar 3, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 3, 2017

@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @fjl and @obscuren to be potential reviewers.

mention-bot commented Mar 3, 2017

@karalabe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zsfelfoldi, @fjl and @obscuren to be potential reviewers.

@karalabe karalabe requested review from fjl and obscuren Mar 3, 2017

@karalabe karalabe added this to the 1.6.0 milestone Mar 3, 2017

@bas-vk

This comment has been minimized.

Show comment
Hide comment
@bas-vk

bas-vk Mar 15, 2017

Member

There is also the --solc commandline flag and admin_setSolc that can be removed?
Afaik these are only used by the rpc methods.

Member

bas-vk commented Mar 15, 2017

There is also the --solc commandline flag and admin_setSolc that can be removed?
Afaik these are only used by the rpc methods.

@fjl

fjl approved these changes Mar 16, 2017

@fjl fjl merged commit 61ede86 into ethereum:master Mar 16, 2017

2 of 4 checks passed

ci/circleci A command timed out during your tests
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brandoncurtis brandoncurtis referenced this pull request Apr 22, 2018

Closed

Method Deprecated #3366

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment