Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin refactor v1 #121

Merged
merged 2 commits into from Aug 2, 2019

Conversation

@marcgarreau
Copy link
Collaborator

commented Aug 2, 2019

What does it do?

First of probably several refactors to bring all prior naming iterations (e.g. nodes, clients, services) to plugin. This focuses on renaming Nodes directory to Plugins and client Redux directory to plugin (+ their resulting ripples).

Note: very many client (and other noun) references within. Not planning on addressing all of them until part 2 or 3.

Does it close any issues?

Partially addresses ethereum/grid#394

marcgarreau added some commits Aug 2, 2019

@ryanio

ryanio approved these changes Aug 2, 2019

Copy link
Collaborator

left a comment

looks good and works for me

@marcgarreau marcgarreau merged commit e670c98 into dev Aug 2, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the plugin-refactor-v1 branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.