Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor service to plugin #127

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@marcgarreau
Copy link
Collaborator

commented Aug 6, 2019

What does it do?

  • ServicesNav -> PluginsNav
  • ServicesNavListItem -> PluginsNavListItem
  • utils refactor
  • settings test refactor
  • etc. client/service -> plugin refactors.

Any helpful background information?

Finishes this task, with the exception of NodeInfo components, which @ryanio has addressed in another PR.

Does it close any issues?

Closes ethereum/grid#394

@ryanio

ryanio approved these changes Aug 7, 2019

@ryanio

ryanio approved these changes Aug 7, 2019

Copy link
Collaborator

left a comment

runs well for me 👍

@marcgarreau marcgarreau merged commit 983dde1 into dev Aug 7, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the plugin-refactor-v5 branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.